logs: allow disabling log collection in jobspec #16962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgross
force-pushed
the
null-logger
branch
2 times, most recently
from
d3e9c5a to
0bf0a91
Compare
schmichael
approved these changes
Apr 21, 2023
| @@ -3,7 +3,7 @@ layout: docs | |||
| page_title: logs Block - Job Specification | |||
| description: |- | |||
| The "logs" block configures the log rotation policy for a task's stdout and | |||
| stderr. Logging is enabled by default with sane defaults. The "logs" block | |||
| stderr. Logging is enabled by default with reasonable defaults. The "logs" block | |||
jrasell
approved these changes
Apr 24, 2023
Some Nomad users ship application logs out-of-band via syslog. For these users having `logmon` (and `docker_logger`) running is unnecessary overhead. Allow disabling the logmon and pointing the task's stdout/stderr to /dev/null. This changeset is the first of several incremental improvements to log collection short of full-on logging plugins. The next step will likely be to extend the internal-only task driver configuration so that cluster administrators can turn off log collection for the entire driver. --- Fixes: #11175 Co-authored-By: Thomas Weber <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some Nomad users ship application logs out-of-band via syslog or the like. For these users having
logmon(anddocker_logger) running is unnecessary overhead. Allow disabling the logmon and pointing the task's stdout/stderr to /dev/null.This changeset is the first of several incremental improvements to log collection short of full-on logging plugins. The next step will likely be to extend the internal-only task driver configuration so that cluster administrators can turn off log collection for the entire driver (as described in #15686 and #14636)
Fixes: #11175
Notes to reviewers:
dockerandraw_exectasks, with and without thelogs.enabledset, including requiring destructive updates to the alloc if we change the value.disable_logging_collectionfield for the driver, I went withenabledhere to be more consistent with other jobspec fields and our inclusive language guidelines. I suspect most folks won't touch it, in any case.LogConfig.Enabled = false. But I've verified it doesn't cause any weird crashing behavior, the panel is just empty.