Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

driver: allow operators to disable logmon process spawning #14636

Closed
jrasell opened this issue Sep 21, 2022 · 0 comments · Fixed by #17196
Closed

driver: allow operators to disable logmon process spawning #14636

jrasell opened this issue Sep 21, 2022 · 0 comments · Fixed by #17196
Assignees
@tgross
Labels
stage/needs-discussion theme/driver theme/logging type/enhancement
Milestone
1.6.0

Comments

@jrasell
Copy link
Member

jrasell commented Sep 21, 2022

PR #6820 added an experimental driver interface which allowed operators to disable logmon process spawning. This interface is only available to builtin drivers as it was not added to the driver capabilities functionality to allow for UX improvements and modifications to the interface.

In some cases, cluster operators would like to disable spawning logmon processes to avoid this additional overhead where the functionality it delivers is not required. It would be good therefore to discuss what changes we should make to the interface, if any, and what needs to be done in order to have this functionality, or equivalent exposed to external drivers.
@tgross tgross mentioned this issue Jan 4, 2023
Closed
This was referenced Apr 21, 2023
Merged
Closed
@tgross tgross self-assigned this Apr 21, 2023
@tgross tgross added this to the 1.5.x milestone Apr 21, 2023
Merged
@tgross tgross mentioned this issue May 15, 2023
Merged
tgross added a commit that referenced this issue May 15, 2023
@tgross
drivers: make internal DisableLogCollection capability public
e0143a3 
The `DisableLogCollection` capability was introduced as an experimental
interface for the Docker driver in 0.10.4. The interface has been stable and
allowing third-party task drivers the same capability would be useful for those
drivers that don't need the additional overhead of logmon.

This PR only makes the capability public. It doesn't yet add it to the
configuration options for the other internal drivers.

Fixes: #14636 #15686
@tgross tgross closed this as completed in bf7b82b May 16, 2023
@tgross tgross modified the milestones: 1.5.x, 1.6.0 May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tgross tgross

Labels
stage/needs-discussion theme/driver theme/logging type/enhancement
Projects
Nomad - Community Issues Triage
Archived in project
Milestone
1.6.0
Development

Successfully merging a pull request may close this issue.

drivers: make internal DisableLogCollection capability public hashicorp/nomad
2 participants
@tgross @jrasell