Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cni fingerprinter multi paths #16083

Closed
shoenig opened this issue Feb 7, 2023 · 1 comment · Fixed by #16163
Closed

cni fingerprinter multi paths #16083

shoenig opened this issue Feb 7, 2023 · 1 comment · Fixed by #16163
Assignees
@shoenig
Labels
theme/cni type/bug
Milestone
1.5.0

Comments

@shoenig
Copy link
Contributor

shoenig commented Feb 7, 2023

#11038 (comment)

We missed that when we did #15452
@shoenig shoenig added this to the 1.5.0 milestone Feb 7, 2023
@shoenig shoenig self-assigned this Feb 13, 2023
shoenig added a commit that referenced this issue Feb 13, 2023
@shoenig
cni: handle multi-path cni_path when fingerprinting plugins
6d84941 
This PR fixes the CNI plugin fingerprinter to take into account the fact
that the cni_path config can be a multi-path (e.g. `/foo:/bar:/baz`).

Accumulate plugins from each of the possible path elements. If scanning
any of the named directory fails, the fingerprinter fails.

Fixes #16083

No CL/BP - has not shipped yet.
@shoenig shoenig mentioned this issue Feb 13, 2023
Merged
shoenig added a commit that referenced this issue Feb 13, 2023
@shoenig
cni: handle multi-path cni_path when fingerprinting plugins (#16163)
c41ccc6 
This PR fixes the CNI plugin fingerprinter to take into account the fact
that the cni_path config can be a multi-path (e.g. `/foo:/bar:/baz`).

Accumulate plugins from each of the possible path elements. If scanning
any of the named directory fails, the fingerprinter fails.

Fixes #16083

No CL/BP - has not shipped yet.
@github-actions GitHub Actions
Copy link

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@shoenig shoenig

Labels
theme/cni type/bug
Projects
None yet
Milestone
1.5.0
Development

Successfully merging a pull request may close this issue.

cni: handle multi-path cni_path when fingerprinting plugins hashicorp/nomad
1 participant
@shoenig