-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fingerprint: add fingerprinting for CNI plugin versions #15452
Conversation
edda990
to
172a136
Compare
172a136
to
324a244
Compare
324a244
to
e20c7c3
Compare
Spot check
|
f696cc0
to
ea5edfb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments, but no blockers. Good one!
The v
stuff in the fingerprint may be worth checking just to make sure it works with constraint
and affinity
.
This PR adds a fingerprinter to set the attribute "plugins.cni.version.<name>" => "<version>" for each CNI plugin in <client>.cni_path (/opt/cni/bin by default).
ea5edfb
to
53e3ad7
Compare
Backporting this so that #14022 can be merged sooner than later; the implicit constraint cannot be injected until users are already on a version of Nomad that fingerprints the CNI plugin. |
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
This PR adds a fingerprinter to set the attribute
"plugins.cni.version.<name>"
-> version of the CNI plugin if present at$client.cni_path
First half of #14022
Second half will be adding an implicit constraint on applicable jobs.
e.g.
Targets 1.5.0