enhancement: UpdateTask when Task is waiting for ShutdownDelay

[DarthBenro008]

Signed-off-by: Hemanth Krishna [email protected]

• Fixes emit TaskEvent for task stops blocked by shutdown_delay #14170
• Adds a new Task Event named TaskWaitingShuttingDownDelay (Open to suggestions)

[hashicorp-cla]

All committers have signed the CLA.

[cesarvspr]

this looks good @DarthBenro008 !

Would you please provide instructions on how can I test it?

[cesarvspr]

see #14775 (comment)

[DarthBenro008]

@cesarvspr , you can create a Task with shutdown delay and then run nomad alloc status . It should show that the Task is waiting for the shutdown delay

[tgross]

Hi @DarthBenro008, this is great!

I've left some suggestions this could be made even better. Also, can you add a changelog entry file? It'll be a file at .changelog/14775.txt that's in the format like this one. For the text, it can be something like:

client: Added a TaskEvent when task shutdown is waiting on shutdown_delay

This just missed the window for Nomad 1.4.0 GA, but once this is merged you can expect this to ship in the next regular release of Nomad. Thanks so much!

[DarthBenro008]

Hi @tgross, thanks a lot for the detailed review! 😃 . I have made the necessary amendments!

[tgross]

LGTM! Thanks @DarthBenro008! This should ship in the next regular patch release of Nomad

[github-actions]

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.