Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

emit TaskEvent for task stops blocked by shutdown_delay #14170

Closed
tgross opened this issue Aug 17, 2022 · 4 comments · Fixed by #14775
Closed

emit TaskEvent for task stops blocked by shutdown_delay #14170

tgross opened this issue Aug 17, 2022 · 4 comments · Fixed by #14775
Assignees
Labels
good first issue hcc/cst Admin - internal help-wanted We encourage community PRs for these issues! theme/client type/enhancement
Milestone

Comments

@tgross
Copy link
Member

tgross commented Aug 17, 2022

When a task shuts down with a shutdown_delay set, there's no Task Event that indicates we're waiting for the task to shut down. It can be useful for debugging what would otherwise look like a "stuck" task to have this in the output of nomad alloc status (and the corresponding pages on the UI).

We've already got a debug-level log entry at the right spot in task_runner.go#L931, so it would be a matter of creating a new Task Event and calling UpdateState for it (similar to task_runner.go#L1143-L1145).

@tgross tgross added type/enhancement theme/client good first issue help-wanted We encourage community PRs for these issues! hcc/cst Admin - internal labels Aug 17, 2022
@DarthBenro008
Copy link
Contributor

Hi @tgross , I'd be happy to send a PR for the same, thanks for the detailed description! :D

@cesarvspr
Copy link

@DarthBenro008 I would be happy to assist if needed, please share your PR with us

@DarthBenro008
Copy link
Contributor

@cesarvspr I have raised a PR!

@tgross tgross self-assigned this Oct 3, 2022
@tgross tgross added this to the 1.4.x milestone Oct 3, 2022
@github-actions
Copy link

github-actions bot commented Feb 4, 2023

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue hcc/cst Admin - internal help-wanted We encourage community PRs for these issues! theme/client type/enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants