Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI 'nomad ui -authenticate' flag for one-time token exchange #10097

Merged
merged 3 commits into from
Mar 8, 2021

Conversation

tgross
Copy link
Member

@tgross tgross commented Feb 26, 2021

The last bit of nomad ui -authenticate. Only the 3a7dba9 and dfd8407 commits are part of this PR; it won't compile without #10095, but I'll rebase it once that's been merged.

Related to #10066 #10091 #10092 #10095 and the implementation of #6054. I'm making this PR to a branch f-nomad-ui-login.

Endpoints for requesting and exchanging one-time tokens via the HTTP
API. Includes documentation updates.
@tgross tgross force-pushed the f-nomad-ui-login-cli branch from 32341b0 to 3a7dba9 Compare February 26, 2021 16:48
@vercel vercel bot temporarily deployed to Preview – nomad February 26, 2021 16:48 Inactive
@tgross tgross added this to the 1.1.0 milestone Feb 26, 2021
@tgross tgross marked this pull request as ready for review February 26, 2021 20:09
@tgross tgross requested review from shoenig and cgbaker February 26, 2021 20:09
Copy link
Contributor

@cgbaker cgbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

@tgross
Copy link
Member Author

tgross commented Mar 1, 2021

The Waypoint project uses the command flag -authenticate, so I've updated this PR to use the same flag for cross-product consistency.

@tgross tgross changed the title CLI 'nomad ui -login' flag for one-time token exchange CLI 'nomad ui -authenticate' flag for one-time token exchange Mar 1, 2021
Copy link
Contributor

@shoenig shoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tgross tgross merged commit e3d812e into f-nomad-ui-login Mar 8, 2021
@tgross tgross deleted the f-nomad-ui-login-cli branch March 8, 2021 15:16
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants