Test cases updated for new notifs

hashicorp · Feb 10, 2023 · f78f14d · f78f14d
1 parent 0c284a5
commit f78f14d
Show file tree

Hide file tree

Showing 7 changed files with 15 additions and 12 deletions.
diff --git a/.changelog/16099.txt b/.changelog/16099.txt
@@ -0,0 +1,3 @@
+```release-note:improvement
+ui: Restyles "toast" notifications in the web UI with the Helios Design System
+```
diff --git a/ui/app/components/variable-form.js b/ui/app/components/variable-form.js
@@ -240,7 +240,7 @@ export default class VariableFormComponent extends Component {
     } catch (error) {
       notifyConflict(this)(error);
       if (!this.hasConflict) {
-        this.flashMnotificationsessages.add({
+        this.notifications.add({
           title: `Error saving ${this.path}`,
           message: error,
           color: 'critical',

diff --git a/ui/tests/acceptance/allocation-detail-test.js b/ui/tests/acceptance/allocation-detail-test.js
@@ -464,11 +464,11 @@ module('Acceptance | allocation detail', function (hooks) {
 
     component.onClick();
 
-    await waitFor('.flash-message.alert-error');
+    await waitFor('.flash-message.alert-critical');
 
     assert.verifySteps(['Transition dispatched.']);
     assert
-      .dom('.flash-message.alert-error')
+      .dom('.flash-message.alert-critical')
       .exists('A toast error message pops up.');
 
     // Clean-up

diff --git a/ui/tests/acceptance/job-run-test.js b/ui/tests/acceptance/job-run-test.js
@@ -352,7 +352,7 @@ module('Acceptance | job run', function (hooks) {
         'We do not navigate away from the page if an error is returned by the API.'
       );
       assert
-        .dom('.flash-message.alert-error')
+        .dom('.flash-message.alert-critical')
         .exists('A toast error message pops up.');
     });
 

diff --git a/ui/tests/acceptance/policies-test.js b/ui/tests/acceptance/policies-test.js
@@ -65,7 +65,7 @@ module('Acceptance | policies', function (hooks) {
     await typeIn('[data-test-policy-name-input]', 'My Fun Policy');
     await click('button[type="submit"]');
     assert
-      .dom('.flash-message.alert-error')
+      .dom('.flash-message.alert-critical')
       .exists('Doesnt let you save a bad name');
     assert.equal(currentURL(), '/policies/new');
     document.querySelector('[data-test-policy-name-input]').value = ''; // clear

diff --git a/ui/tests/acceptance/token-test.js b/ui/tests/acceptance/token-test.js
@@ -213,10 +213,10 @@ module('Acceptance | tokens', function (hooks) {
     // TTL Action
     await Jobs.visit();
     assert
-      .dom('.flash-message.alert-error button')
+      .dom('.flash-message.alert-warning button')
       .exists('A global alert exists and has a clickable button');
 
-    await click('.flash-message.alert-error button');
+    await click('.flash-message.alert-warning button');
     assert.equal(
       currentURL(),
       '/settings/tokens',
@@ -313,7 +313,7 @@ module('Acceptance | tokens', function (hooks) {
     // short-circuiting our Ember Concurrency loop.
     setTimeout(() => {
       assert
-        .dom('.flash-message.alert-error')
+        .dom('.flash-message.alert-warning')
         .doesNotExist('No notification yet for a token with 10m5s left');
       notificationNotRendered();
       setTimeout(async () => {
@@ -322,7 +322,7 @@ module('Acceptance | tokens', function (hooks) {
         });
 
         assert
-          .dom('.flash-message.alert-error')
+          .dom('.flash-message.alert-warning')
           .exists('Notification is rendered at the 10m mark');
         notificationRendered();
         run.cancelTimers();

diff --git a/ui/tests/acceptance/variables-test.js b/ui/tests/acceptance/variables-test.js
@@ -362,9 +362,9 @@ module('Acceptance | variables', function (hooks) {
     assert.equal(currentURL(), '/variables/new');
     await typeIn('.path-input', 'foo/bar');
     await click('button[type="submit"]');
-    assert.dom('.flash-message.alert-error').exists();
-    await click('.flash-message.alert-error .close-button');
-    assert.dom('.flash-message.alert-error').doesNotExist();
+    assert.dom('.flash-message.alert-critical').exists();
+    await click('.flash-message.alert-critical .hds-dismiss-button');
+    assert.dom('.flash-message.alert-critical').doesNotExist();
 
     await typeIn('.key-value label:nth-child(1) input', 'myKey');
     await typeIn('.key-value label:nth-child(2) input', 'superSecret');