Skip to content

Commit

Permalink
docs: changelog for PR #11783 (#11812)
Browse files Browse the repository at this point in the history
  • Loading branch information
@tgross
tgross authored Jan 10, 2022
1 parent 7593975 commit ef93ab2
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions .changelog/11783.txt
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:bug
template: Fixed a bug where templates did not receive updated vault token if `change_mode = "noop"` was set
```

This comment has been minimized.

Sign in to view

Copy link
@grembo

grembo Jan 11, 2022 •
edited
Loading

Contributor

@tgross Minor nit: As the template stanza also has an option called change_mode = "noop", this is slightly ambiguous and therefore could be misunderstood.

Adding "in the job definition's vault stanza" would make it 100% clear:

template: Fixed a bug where templates did not receive an updated
          vault token if `change_mode = "noop"` was set in the job
          definition's vault stanza

This comment has been minimized.

Sign in to view

Copy link
@tgross

tgross Jan 11, 2022

Author Member

Oh thank you, yes that's important!

0 comments on commit ef93ab2

Please sign in to comment.