go style; update comments

client/client.go

@@ -1016,6 +1016,8 @@ func (c *Client) updateNodeFromFingerprint(response *cstructs.FingerprintRespons
 	return c.config.Node
 }
 
+// updateNodeFromHealthCheck receives a health check response and updates the
+// node accordingly
 func (c *Client) updateNodeFromHealthCheck(response *cstructs.HealthCheckResponse) *structs.Node {
 	c.configLock.Lock()
 	defer c.configLock.Unlock()

client/driver/docker.go

@@ -589,7 +589,7 @@ func (d *DockerDriver) HealthCheck(req *cstructs.HealthCheckRequest, resp *cstru
 // interval at which to do them.
 func (d *DockerDriver) GetHealthCheckInterval(req *cstructs.HealthCheckIntervalRequest, resp *cstructs.HealthCheckIntervalResponse) error {
 	resp.Eligible = true
-	resp.Period = 3 * time.Second
+	resp.Period = 1 * time.Minute
 	return nil
 }
 

client/driver/docker_test.go

@@ -267,8 +267,6 @@ func TestDockerDriver_Check_DockerHealthStatus(t *testing.T) {
 
 	require := require.New(t)
 
-	// This seems fragile, so we might need to reconsider this test if it
-	// proves flaky
 	expectedAddr, err := sockaddr.GetInterfaceIP("docker0")
 	if err != nil {
 		t.Fatalf("unable to get ip for docker0: %v", err)

nomad/structs/node.go

@@ -15,12 +15,16 @@ type DriverInfo struct {
 	UpdateTime        time.Time
 }
 
+// MergeHealthCheck merges information from a health check for a drier into a
+// node's driver info
 func (di *DriverInfo) MergeHealthCheck(other *DriverInfo) {
 	di.Healthy = other.Healthy
 	di.HealthDescription = other.HealthDescription
 	di.UpdateTime = other.UpdateTime
 }
 
+// MergeFingerprint merges information from fingerprinting a node for a driver
+// into a node's driver info for that driver.
 func (di *DriverInfo) MergeFingerprintInfo(other *DriverInfo) {
 	di.Detected = other.Detected
 	di.Attributes = other.Attributes