add non-empty string validation for datacenters

hashicorp · May 3, 2019 · de25a7b · de25a7b
1 parent 01c267b
commit de25a7b
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/nomad/structs/structs.go b/nomad/structs/structs.go
@@ -3382,6 +3382,12 @@ func (j *Job) Validate() error {
 	}
 	if len(j.Datacenters) == 0 {
 		mErr.Errors = append(mErr.Errors, errors.New("Missing job datacenters"))
+	} else {
+		for _, v := range j.Datacenters {
+			if v == "" {
+				mErr.Errors = append(mErr.Errors, errors.New("Job datacenter must be non-empty string"))
+			}
+		}
 	}
 	if len(j.TaskGroups) == 0 {
 		mErr.Errors = append(mErr.Errors, errors.New("Missing job task groups"))