Skip to content

Commit

Permalink
executor_universal_linux log a link to the docs on cgroup error
Browse files Browse the repository at this point in the history
  • Loading branch information
langmartin committed Jul 24, 2019
1 parent 0fed5eb commit c7cd018
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions drivers/shared/executor/executor_universal_linux.go
Original file line number Diff line number Diff line change
Expand Up @@ -77,10 +77,12 @@ func (e *UniversalExecutor) configureResourceContainer(pid int) error {

err := configureBasicCgroups(cfg)
if err != nil {
// Debug this error to help diagnose cases where nomad is run with too few
// Log this error to help diagnose cases where nomad is run with too few
// permissions, but don't return an error. There is no separate check for
// cgroup creation permissions, so this may be the happy path.
e.logger.Debug("failed to create cgroup", "error", err)
e.logger.Warn("failed to create cgroup",
"docs", "https://www.nomadproject.io/docs/drivers/raw_exec.html#no_cgroups",
"error", err)
return nil
}
e.resConCtx.groups = cfg.Cgroups
Expand Down

0 comments on commit c7cd018

Please sign in to comment.