Skip to content

Commit

Permalink
Backport of Fix error handling in Client consulDiscoveryImpl into rel…
Browse files Browse the repository at this point in the history
…ease/1.3.x (#14455)

This pull request was automerged via backport-assistant
  • Loading branch information
hc-github-team-nomad-core authored Sep 2, 2022
1 parent f5dbb1a commit 93eb741
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 0 deletions.
3 changes: 3 additions & 0 deletions .changelog/14431.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:bug
client: Fixed bug where clients could attempt to connect to servers with invalid addresses retrieved from Consul.
```
1 change: 1 addition & 0 deletions client/client.go
Original file line number Diff line number Diff line change
Expand Up @@ -2840,6 +2840,7 @@ DISCOLOOP:
addr, err := net.ResolveTCPAddr("tcp", p)
if err != nil {
mErr.Errors = append(mErr.Errors, err)
continue
}
srv := &servers.Server{Addr: addr}
nomadServers = append(nomadServers, srv)
Expand Down

0 comments on commit 93eb741

Please sign in to comment.