Use Dockerhub Mirror. (#9220)

Dockerhub is going to rate limit unauthenticated pulls.

Use our HashiCorp internal mirror for builds run through CircleCI.

Co-authored-by: Mahmood Ali <[email protected]>

.circleci/config/config.yml

@@ -24,7 +24,7 @@ executors:
   go:
     working_directory: /go/src/github.com/hashicorp/nomad
     docker:
-      - image: golang:1.15.1
+      - image: docker.mirror.hashicorp.services/golang:1.15.1
     environment:
       <<: *common_envs
       GOPATH: /go

.circleci/config/jobs/algolia_index.yml

@@ -1,5 +1,5 @@
 docker:
-  - image: node:12
+  - image: docker.mirror.hashicorp.services/node:12
 steps:
   - checkout
   - run:

.circleci/config/jobs/test-ui.yml

@@ -1,5 +1,5 @@
 docker:
-  - image: circleci/node:10-browsers
+  - image: docker.mirror.hashicorp.services/circleci/node:10-browsers
     environment:
       # See https://git.io/vdao3 for details.
       JOBS: 2
@@ -28,4 +28,4 @@ steps:
   - store_test_results:
       path: /tmp/test-reports
   - store_artifacts:
-      path: /tmp/test-reports
+      path: /tmp/test-reports

.circleci/config/jobs/test-windows.yml

@@ -22,7 +22,7 @@ steps:
         make deps
   - run:
       name: Pre-download docker test image
-      command: docker pull hashicorpnomad/busybox-windows:server2016-0.1
+      command: docker pull docker.mirror.hashicorp.services/hashicorpnomad/busybox-windows:server2016-0.1
   - run:
       name: Build nomad
       command: | 

.circleci/config/jobs/website-docker-image.yml

@@ -1,5 +1,5 @@
 docker:
-  - image: circleci/buildpack-deps
+  - image: docker.mirror.hashicorp.services/circleci/buildpack-deps
 shell: /usr/bin/env bash -euo pipefail -c
 steps:
   - checkout

drivers/docker/docklog/docker_logger_test.go

@@ -17,13 +17,20 @@ import (
 )
 
 func testContainerDetails() (image string, imageName string, imageTag string) {
+	name := "busybox"
+	tag := "1"
+
 	if runtime.GOOS == "windows" {
-		return "hashicorpnomad/busybox-windows:server2016-0.1",
-			"hashicorpnomad/busybox-windows",
-			"server2016-0.1"
+		name = "hashicorpnomad/busybox-windows"
+		tag = "server2016-0.1"
+	}
+
+	if testutil.IsCI() {
+		// In CI, use HashiCorp Mirror to avoid DockerHub rate limiting
+		name = "docker.mirror.hashicorp.services/" + name
 	}
 
-	return "busybox:1", "busybox", "1"
+	return name + ":" + tag, name, tag
 }
 
 func TestDockerLogger_Success(t *testing.T) {

drivers/docker/driver_test.go

@@ -333,7 +333,7 @@ func TestDockerDriver_Start_StoppedContainer(t *testing.T) {
 	if runtime.GOOS != "windows" {
 		imageID, err = d.Impl().(*Driver).loadImage(task, &taskCfg, client)
 	} else {
-		image, lErr := client.InspectImage("hashicorpnomad/busybox-windows:server2016-0.1")
+		image, lErr := client.InspectImage(taskCfg.Image)
 		err = lErr
 		if image != nil {
 			imageID = image.ID

drivers/docker/driver_windows_test.go

@@ -6,13 +6,19 @@ import (
 	"testing"
 
 	"github.com/hashicorp/nomad/client/allocdir"
+	tu "github.com/hashicorp/nomad/testutil"
 )
 
 func newTaskConfig(variant string, command []string) TaskConfig {
 	// busyboxImageID is an id of an image containing nanoserver windows and
 	// a busybox exe.
 	busyboxImageID := "hashicorpnomad/busybox-windows:server2016-0.1"
 
+	if tu.IsCI() {
+		// In CI, use HashiCorp Mirror to avoid DockerHub rate limiting
+		busyboxImageID = "docker.mirror.hashicorp.services/" + busyboxImageID
+	}
+
 	return TaskConfig{
 		Image:            busyboxImageID,
 		ImagePullTimeout: "5m",

website/Dockerfile

@@ -1,4 +1,4 @@
-FROM node:10.16.3-alpine
+FROM docker.mirror.hashicorp.services/node:10.16.3-alpine
 RUN apk add --update --no-cache git make g++ automake autoconf libtool nasm libpng-dev
 
 COPY ./package.json /website/package.json