backport of commit 1065769

hashicorp · Dec 19, 2024 · 8fa20fd · 8fa20fd
1 parent 1c12fc5
commit 8fa20fd
Show file tree

Hide file tree

Showing 623 changed files with 1,653 additions and 11,963 deletions.
diff --git a/.changelog/24168.txt b/.changelog/24168.txt
diff --git a/.changelog/24304.txt b/.changelog/24304.txt
diff --git a/.changelog/24316.txt b/.changelog/24316.txt
diff --git a/.changelog/24319.txt b/.changelog/24319.txt
diff --git a/.changelog/24363.txt b/.changelog/24363.txt
diff --git a/.changelog/24409.txt b/.changelog/24409.txt
diff --git a/.changelog/24410.txt b/.changelog/24410.txt
diff --git a/.changelog/24415.txt b/.changelog/24415.txt
diff --git a/.changelog/24423.txt b/.changelog/24423.txt
diff --git a/.changelog/24432.txt b/.changelog/24432.txt
diff --git a/.changelog/24442.txt b/.changelog/24442.txt
diff --git a/.changelog/24456.txt b/.changelog/24456.txt
diff --git a/.changelog/24466.txt b/.changelog/24466.txt
diff --git a/.changelog/24489.txt b/.changelog/24489.txt
diff --git a/.changelog/24494.txt b/.changelog/24494.txt
diff --git a/.changelog/24495.txt b/.changelog/24495.txt
diff --git a/.changelog/24513.txt b/.changelog/24513.txt
diff --git a/.changelog/24522.txt b/.changelog/24522.txt
diff --git a/.changelog/24538.txt b/.changelog/24538.txt
diff --git a/.changelog/24540.txt b/.changelog/24540.txt
diff --git a/.changelog/24541.txt b/.changelog/24541.txt
diff --git a/.changelog/24542.txt b/.changelog/24542.txt
diff --git a/.changelog/24556.txt b/.changelog/24556.txt
diff --git a/.changelog/24561.txt b/.changelog/24561.txt
diff --git a/.changelog/24594.txt b/.changelog/24594.txt
diff --git a/.changelog/24601.txt b/.changelog/24601.txt
diff --git a/.changelog/24620.txt b/.changelog/24620.txt
diff --git a/.changelog/24622.txt b/.changelog/24622.txt
diff --git a/.changelog/24642.txt b/.changelog/24642.txt
diff --git a/.changelog/24644.txt b/.changelog/24644.txt
diff --git a/.changelog/24649.txt b/.changelog/24649.txt
diff --git a/.changelog/24650.txt b/.changelog/24650.txt
diff --git a/.changelog/24655.txt b/.changelog/24655.txt
diff --git a/.changelog/24668.txt b/.changelog/24668.txt
diff --git a/.changelog/24683.txt b/.changelog/24683.txt
diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md
diff --git a/.github/workflows/backport.yml b/.github/workflows/backport.yml
@@ -63,7 +63,7 @@ jobs:
           secrets: |-
             kv/data/teams/nomad/slack-webhooks feed-nomad | SLACK_FEED_NOMAD ;
       - name: Send slack notification on failure
-        uses: slackapi/slack-github-action@485a9d42d3a73031f12ec201c457e2162c45d02d # v2.0.0
+        uses: slackapi/slack-github-action@37ebaef184d7626c5f204ab8d3baff4262dd30f0 # v1.27.0
         with:
           payload: |
             {

diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -90,15 +90,15 @@ jobs:
         with:
           ref: ${{ github.event.inputs.build-ref }}
       - name: Setup go
-        uses: actions/setup-go@41dfa10bad2bb2ae585af6ee5bb4d7d973ad74ed # v5.1.0
+        uses: actions/setup-go@0a12ed9d6a96ab950c8f026ed9f722fe0da7ef32 # v5.0.2
         with:
           go-version: ${{ needs.get-go-version.outputs.go-version }}
 
       - name: Build dependencies
         run: make deps
 
       - name: Setup node and yarn
-        uses: actions/setup-node@39370e3970a6d050c480ffad4ff0ed4d3fdee5af # v4.1.0
+        uses: actions/setup-node@0a44ba7841725637a19e28fa30b79a866c81b0a6 # v4.0.4
         with:
           node-version: "18"
           cache-dependency-path: "ui/yarn.lock"
@@ -142,15 +142,15 @@ jobs:
         with:
           ref: ${{ github.event.inputs.build-ref }}
       - name: Setup go
-        uses: actions/setup-go@41dfa10bad2bb2ae585af6ee5bb4d7d973ad74ed # v5.1.0
+        uses: actions/setup-go@0a12ed9d6a96ab950c8f026ed9f722fe0da7ef32 # v5.0.2
         with:
           go-version: ${{ needs.get-go-version.outputs.go-version }}
 
       - name: Build dependencies
         run: make deps
 
       - name: Setup node and yarn
-        uses: actions/setup-node@39370e3970a6d050c480ffad4ff0ed4d3fdee5af # v4.1.0
+        uses: actions/setup-node@0a44ba7841725637a19e28fa30b79a866c81b0a6 # v4.0.4
         with:
           node-version: "18"
           cache-dependency-path: "ui/yarn.lock"
@@ -265,15 +265,15 @@ jobs:
         run: git config --global url.'https://${{ env.ELEVATED_GITHUB_TOKEN }}@github.com'.insteadOf 'https://github.com'
 
       - name: Setup go
-        uses: actions/setup-go@41dfa10bad2bb2ae585af6ee5bb4d7d973ad74ed # v5.1.0
+        uses: actions/setup-go@0a12ed9d6a96ab950c8f026ed9f722fe0da7ef32 # v5.0.2
         with:
           go-version: ${{ needs.get-go-version.outputs.go-version }}
 
       - name: Build dependencies
         run: make deps
 
       - name: Setup node and yarn
-        uses: actions/setup-node@39370e3970a6d050c480ffad4ff0ed4d3fdee5af # v4.1.0
+        uses: actions/setup-node@0a44ba7841725637a19e28fa30b79a866c81b0a6 # v4.0.4
         with:
           node-version: "18"
           cache-dependency-path: "ui/yarn.lock"
@@ -356,7 +356,7 @@ jobs:
         goos: [linux]
         goarch: [amd64]
     steps:
-      - uses: actions/setup-go@41dfa10bad2bb2ae585af6ee5bb4d7d973ad74ed # v5.1.0
+      - uses: actions/setup-go@0a12ed9d6a96ab950c8f026ed9f722fe0da7ef32 # v5.0.2
         with:
           go-version: ${{needs.get-go-version.outputs.go-version}}
       - uses: actions/download-artifact@fa0a91b85d4f404e444e00e005971372dc801d16 # v4.1.8
@@ -377,25 +377,6 @@ jobs:
           echo "::group::Smoke test binary"
           docker run --rm -v "$PWD:/src" registry.access.redhat.com/ubi7/ubi-minimal:7.9-1057 /src/nomad version
 
-  handle-failure:
-    needs:
-      - get-go-version
-      - get-product-version
-      - generate-metadata-file
-      - build-other
-      - build-linux
-      - build-darwin
-      - build-docker
-      - minimum-os
-    if: always() && github.event_name == 'push' && contains(needs.*.result, 'failure')
-    uses: ./.github/workflows/test-failure-notification.yml
-    secrets: inherit
-    with:
-      actor: ${{ github.triggering_actor }}
-      git-branch: ${{ github.ref_name }}
-      workflow-run-id: ${{ github.run_id }}
-      workflow-name: ${{ github.workflow }}
-
 permissions:
   contents: read
   id-token: write
diff --git a/.github/workflows/checks.yaml b/.github/workflows/checks.yaml
@@ -41,9 +41,9 @@ jobs:
       - name: Git config token
         if: endsWith(github.repository, '-enterprise')
         run: git config --global url.'https://${{ env.ELEVATED_GITHUB_TOKEN }}@github.com'.insteadOf 'https://github.com'
-      - uses: actions/setup-go@41dfa10bad2bb2ae585af6ee5bb4d7d973ad74ed # v5.1.0
+      - uses: actions/setup-go@0a12ed9d6a96ab950c8f026ed9f722fe0da7ef32 # v5.0.2
         with:
-          cache: ${{ contains(runner.name, 'Github Actions') }}
+          cache: true
           go-version-file: .go-version
           cache-dependency-path: '**/go.sum'
       - name: Run make check

diff --git a/.github/workflows/ember-test-audit.yml b/.github/workflows/ember-test-audit.yml
@@ -0,0 +1,87 @@
+name: Ember test audit comparison
+on:
+  pull_request:
+    paths:
+    - '.github/workflows/ember*'
+    - 'ui/**'
+
+defaults:
+  run:
+    working-directory: ui
+
+# There’s currently no way to share steps between jobs so there’s a lot of duplication
+# for running the audit for the base and PR.
+jobs:
+  time-base:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
+        with:
+          ref: ${{ github.event.pull_request.base.sha }}
+      - uses: nanasess/setup-chromedriver@42cc2998329f041de87dc3cfa33a930eacd57eaa # v2.2.2
+      - name: Use Node.js
+        uses: actions/setup-node@0a44ba7841725637a19e28fa30b79a866c81b0a6 # v4.0.4
+        with:
+          node-version: '18'
+      - run: yarn --frozen-lockfile
+      - run: mkdir -p /tmp/test-reports
+      - run: npx ember-test-audit 1 --json --output ../base-audit.json
+      - name: Upload result
+        uses: actions/upload-artifact@b4b15b8c7c6ac21ea08fcf65892d2ee8f75cf882 # v4.4.3
+        with:
+          name: base-audit
+          path: base-audit.json
+  time-pr:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
+      - uses: nanasess/setup-chromedriver@42cc2998329f041de87dc3cfa33a930eacd57eaa # v2.2.2
+      - name: Use Node.js
+        uses: actions/setup-node@0a44ba7841725637a19e28fa30b79a866c81b0a6 # v4.0.4
+        with:
+          node-version: '18'
+      - run: yarn --frozen-lockfile
+      - run: mkdir -p /tmp/test-reports
+      - run: npx ember-test-audit 1 --json --output ../pr-audit.json
+      - name: Upload result
+        uses: actions/upload-artifact@b4b15b8c7c6ac21ea08fcf65892d2ee8f75cf882 # v4.4.3
+        with:
+          name: pr-audit
+          path: pr-audit.json
+  compare:
+    needs: [time-base, time-pr]
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/download-artifact@fa0a91b85d4f404e444e00e005971372dc801d16 # v4.1.8
+        with:
+          name: base-audit
+      - uses: actions/download-artifact@fa0a91b85d4f404e444e00e005971372dc801d16 # v4.1.8
+        with:
+          name: pr-audit
+      - uses: backspace/ember-test-audit-comparison-action@21e9492d0033bc7e84b6189ae94537a6ed045cfa # v2
+        with:
+          base-report-path: base-audit.json
+          comparison-report-path: pr-audit.json
+          base-identifier: ${{ github.event.pull_request.base.ref }}
+          comparison-identifier: ${{ github.event.pull_request.head.sha }}
+          timing-output-path: audit-diff.md
+          flakiness-output-path: flakiness-report.md
+      - uses: marocchino/sticky-pull-request-comment@331f8f5b4215f0445d3c07b4967662a32a2d3e31 # v2.9.0
+        with:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+          path: audit-diff.md
+      - name: Check for existence of flakiness report
+        id: check_file
+        uses: andstor/file-existence-action@076e0072799f4942c8bc574a82233e1e4d13e9d6 # v3.0.0
+        with:
+          files: "flakiness-report.md"
+      - name: comment PR
+        if: steps.check_file.outputs.files_exists == 'true'
+        uses: mshick/add-pr-comment@b8f338c590a895d50bcbfa6c5859251edc8952fc # v2.8.2
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+        with:
+          message-path: flakiness-report.md
+permissions:
+  contents: read
+  pull-requests: write
diff --git a/.github/workflows/lock.yml b/.github/workflows/lock.yml
@@ -11,18 +11,16 @@ jobs:
       - uses: dessant/lock-threads@1bf7ec25051fe7c00bdd17e6a7cf3d7bfb7dc771 # v5.0.1
         with:
           github-token: ${{ github.token }}
-          process-only: 'issues, prs'
-          issue-comment: >
+          issue-lock-comment: >
             I'm going to lock this issue because it has been closed for _120 days_ ⏳. This helps our maintainers find and focus on the active issues.
 
             If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.
-          issue-inactive-days: '120'
-          pr-comment: >
+          issue-lock-inactive-days: '120'
+          pr-lock-comment: >
             I'm going to lock this pull request because it has been closed for _120 days_ ⏳. This helps our maintainers find and focus on the active contributions.
 
             If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.
-          pr-inactive-days: '120'
-
+          pr-lock-inactive-days: '120'
 permissions:
-  issues: write
-  pull-requests: write
+  contents: read
+