Merge pull request #9334 from hashicorp/b-pin-node-version

ui: Pin ui node version
hashicorp · Nov 12, 2020 · 809b6b9 · 809b6b9
2 parents b53638a + e65b27e
commit 809b6b9
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/scripts/release/Dockerfile b/scripts/release/Dockerfile
@@ -35,7 +35,7 @@ RUN /tmp/scripts/vagrant-linux-unpriv-ui.sh
 COPY ./scripts/release/docker-build-all /tmp/scripts/docker-build-all
 
 # Update PATH with GO bin, yarn, and node
-ENV NODE_VERSION=v10.15.3
+ENV NODE_VERSION=v12.19.0
 ENV GOPATH="/opt/gopath" \
     PATH="/home/vagrant/.nvm/versions/node/${NODE_VERSION}/bin:/home/vagrant/bin:/opt/gopath/bin:/home/vagrant/.yarn/bin:/home/vagrant/.config/yarn/global/node_modules/.bin:$PATH"
 

diff --git a/scripts/vagrant-linux-unpriv-ui.sh b/scripts/vagrant-linux-unpriv-ui.sh
@@ -9,8 +9,9 @@ export NVM_DIR="/home/vagrant/.nvm"
 [ -s "$NVM_DIR/nvm.sh" ] && . "$NVM_DIR/nvm.sh"  # This loads nvm
 
 # Install Node, Ember CLI, and Phantom for UI development
-nvm install 12
-nvm alias default 12
+# Use exact full version version (e.g. not 12) and update scripts/release/Dockerfile
+nvm install 12.19.0
+nvm alias default 12.19.0
 npm install -g ember-cli
 
 # Install Yarn for front-end dependency management