Skip to content

Commit

Permalink
refactor scheduler tests for node down/disconnected
Browse files Browse the repository at this point in the history
While working on #20462 #12319 I found that some of our scheduler tests around
down nodes or disconnected clients were enforcing invariants that were
unclear. This changeset pulls out some minor refactorings so that the bug fix PR
is easier to review. This includes:

* Migrating a few tests from `testify` to `shoenig/test` that I'm going to touch
  in #12319 anyways.
* Adding test names to the node down test
* Update the disconnected client test so that we always re-process the
  pending/blocked eval it creates; this eliminates 2 redundant sub-tests.
* Update the disconnected client test assertions so that they're explicit in the
  test setup rather than implied by whether we re-process the pending/blocked
  eval.

Ref: #20462
Ref: #12319
  • Loading branch information
tgross committed May 22, 2024
1 parent a3b1810 commit 28c7a46
Showing 1 changed file with 108 additions and 113 deletions.
Loading

0 comments on commit 28c7a46

Please sign in to comment.