Skip to content

Commit

Permalink
[ui] Small-screen styles for exec window (#19332)
Browse files Browse the repository at this point in the history
* Phones can exec too

* De-magic breakpoints
  • Loading branch information
philrenaud authored Dec 11, 2023
1 parent 99d72b7 commit 268e92e
Show file tree
Hide file tree
Showing 3 changed files with 28 additions and 0 deletions.
3 changes: 3 additions & 0 deletions .changelog/19332.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:improvement
ui: make the exec window look nicer on mobile screens
```
21 changes: 21 additions & 0 deletions ui/app/styles/components/exec-window.scss
Original file line number Diff line number Diff line change
Expand Up @@ -155,3 +155,24 @@
}
}
}
// Media query for small screens
@media ($breakpoint-mobile) {
.exec-window {
width: 100vw;
height: 100vh;
flex-direction: column;
position: static;
.task-group-tree {
flex: 0 0 auto;
min-height: 50px;
max-height: 300px;
overflow-y: auto;
width: 100%;
}
.terminal-container {
flex: 1 0 auto;
width: 100%;
height: auto;
}
}
}
4 changes: 4 additions & 0 deletions ui/app/styles/core/variables.scss
Original file line number Diff line number Diff line change
Expand Up @@ -65,3 +65,7 @@ $control-padding-vertical: calc(0.375em - #{$control-border-width});
$control-padding-horizontal: calc(0.625em - #{$control-border-width});
$button-padding-vertical: calc(0.375em - #{$button-border-width});
$button-padding-horizontal: 0.75em;

$breakpoint-mobile: 'max-width: 768px';
$breakpoint-tablet: 'min-width: 769px';
$breakpoint-desktop: 'min-width: 1088px';

0 comments on commit 268e92e

Please sign in to comment.