-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Promtail Nomad Pack #46
Conversation
Hey @rigrassm, thanks for the contribution, and congrats on being the first community pack PR! On first glance this looks great. We'll take a shot at configuring and deploying this to a test cluster early next week and assuming all is well, we can get this merged shortly. Thanks again! |
Sounds good! I've got a whole bunch of jobs I've created over the last year that will definitely benefit from being "packed". I'll probably be submitting a pack for the Openstack Cinder CSI driver on Monday. Really hoping to see some traction on this open feature request for Nomad now as it would make deploying common stateful container workloads incredibly simple! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great to me. One minor tweak necessary to get the syntax working properly, but other than that it LGTM.
EDIT: also the http_port might not be getting thread thru properly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking really good and thanks so much for this!
Along with some inline comments I would love if we could format the variables file so it confirms to HCL formatting.
A non-blocking comment would be that we have a number of top level promtail configuration options as their own variable; I wonder if this would be better suited and easier to understand if we had a single object which detailed these?
Co-authored-by: James Rasell <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great, a couple final comments and suggestions and then I think we are good to merge. Thanks so much!
Co-authored-by: James Rasell <[email protected]>
Co-authored-by: James Rasell <[email protected]>
Co-authored-by: James Rasell <[email protected]>
Co-authored-by: James Rasell <[email protected]>
Co-authored-by: James Rasell <[email protected]>
Co-authored-by: James Rasell <[email protected]>
Co-authored-by: James Rasell <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much @rigrassm!
@jrasell Just came across this blog post, , did this PR qualify me for the first community provided pack contribution backpack?? |
This PR adds a Nomad Pack for the Promtail application.