Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add exec support #85

Closed
wants to merge 1 commit into from
Closed

add exec support #85

wants to merge 1 commit into from

Conversation

drewbailey
Copy link
Contributor

Creating a Draft PR containing WIP for basic exec support.

I don't think we'll easily be able to support TTY without significant work in handling / upgrading connections to websockets, we may be able to shim the docker go api package to use their exec command against a podman endpoint

@towe75
Copy link
Collaborator

towe75 commented Jan 22, 2021

I checked some code and found that both websocket and raw tcp can be used:

Maybe we can borrow/share some code from there?
Documentation is rather poor, i could not find any details whatsoever.

@towe75
Copy link
Collaborator

towe75 commented Jan 24, 2021

@drewbailey could not resist to give it a try. Please take a look at my branch 55d4420

I ported podmans own attach.go to fit into our client structure. I've got a working interactive cli (nomad alloc exec) and web-shell, also scripted consul health checks are and using e.g. pipelines in a shell is also ok.

For sure it needs some polishing and something is still wrong with terminal/window resizing - although i did the necessary plumbing and neither nomad nor podman complain about something.

I am also not sure if stderr forwarding works correctly in interactive mode, never tried the consul client so i don't know how it should behave.

It's certainly a very good starting point and it might even be enough for master.
Be aware that it must be adopted to my actor branch later.

@towe75
Copy link
Collaborator

towe75 commented Jan 24, 2021

Resize problem seems to be a podman bug, see containers/podman#7102

Base automatically changed from master to main March 3, 2021 20:39
@towe75
Copy link
Collaborator

towe75 commented Mar 21, 2021

@drewbailey : can we close this one in favor of #87 ?

@drewbailey drewbailey closed this Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants