Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #56 Plumb through Nomad network -> dns to podman #78

Merged
merged 1 commit into from
Mar 22, 2021
Merged

Issue #56 Plumb through Nomad network -> dns to podman #78

merged 1 commit into from
Mar 22, 2021

Conversation

towe75
Copy link
Collaborator

@towe75 towe75 commented Dec 27, 2020

Fixes #56

@towe75
Copy link
Collaborator Author

towe75 commented Jan 22, 2021

@drewbailey PTAL. It's a small change and we can merge/release it after your review.

Base automatically changed from master to main March 3, 2021 20:39
@towe75 towe75 force-pushed the i56_dns_plumbing branch from a771933 to 56cb338 Compare March 21, 2021 09:59
@towe75
Copy link
Collaborator Author

towe75 commented Mar 21, 2021

@drewbailey : bump. I rebased it to current main branch.

drewbailey
drewbailey approved these changes Mar 22, 2021
View reviewed changes
Copy link
Contributor

@drewbailey drewbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@towe75 towe75 merged commit a50f006 into main Mar 22, 2021
@towe75 towe75 deleted the i56_dns_plumbing branch March 22, 2021 13:40
@pabloyoyoista pabloyoyoista mentioned this pull request Apr 13, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drewbailey drewbailey drewbailey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Plumb through Nomad network -> dns to podman
2 participants
@towe75 @drewbailey