podman http api client

.github/machinesetup.sh

@@ -1,8 +1,8 @@
 #!/bin/bash -e
 
-# add podman repository
-echo "deb http://ppa.launchpad.net/projectatomic/ppa/ubuntu $(lsb_release -cs) main" > /etc/apt/sources.list.d/podman.list
-apt-key adv --recv-keys --keyserver keyserver.ubuntu.com 018BA5AD9DF57A4448F0E6CF8BECF1637AD8C79D
+# add podman 2.x repository
+echo "deb https://download.opensuse.org/repositories/devel:/kubic:/libcontainers:/stable/xUbuntu_18.04/ /" | tee /etc/apt/sources.list.d/devel:kubic:libcontainers:stable.list
+curl -L https://download.opensuse.org/repositories/devel:/kubic:/libcontainers:/stable/xUbuntu_18.04/Release.key | apt-key add -
 
 # Ignore apt-get update errors to avoid failing due to misbehaving repo;
 # true errors would fail in the apt-get install phase
@@ -25,37 +25,37 @@ podman info
 echo "====== Podman version:"
 podman version
 
-# enable varlink socket (not included in ubuntu package)
-cat > /etc/systemd/system/io.podman.service << EOF
+# enable http socket (not included in ubuntu package)
+cat > /etc/systemd/system/podman.service << EOF
 [Unit]
-Description=Podman Remote API Service
-Requires=io.podman.socket
-After=io.podman.socket
-Documentation=man:podman-varlink(1)
+Description=Podman API Service
+Requires=podman.socket
+After=podman.socket
+Documentation=man:podman-system-service(1)
+StartLimitIntervalSec=0
 
 [Service]
 Type=simple
-ExecStart=/usr/bin/podman varlink unix:%t/podman/io.podman --timeout=60000
-TimeoutStopSec=30
-KillMode=process
+ExecStart=/usr/bin/podman system service
 
 [Install]
 WantedBy=multi-user.target
-Also=io.podman.socket
+Also=podman.socket
 EOF
 
-cat > /etc/systemd/system/io.podman.socket << EOF
+cat > /etc/systemd/system/podman.socket << EOF
 [Unit]
-Description=Podman Remote API Socket
-Documentation=man:podman-varlink(1)
+Description=Podman API Socket
+Documentation=man:podman-system-service(1)
 
 [Socket]
-ListenStream=%t/podman/io.podman
-SocketMode=0600
+ListenStream=%t/podman/podman.sock
+SocketMode=0660
 
 [Install]
-WantedBy=sockets.targett
+WantedBy=sockets.target
 EOF
 
 systemctl daemon-reload
-systemctl start io.podman
+# enable http api
+systemctl start podman

.golangci.yml

@@ -54,6 +54,8 @@ linters-settings:
   gofmt:
     # simplify code: gofmt with `-s` option, true by default
     simplify: true
+  maligned:
+    suggest-new: true
 
 
 linters:

README.md

@@ -44,11 +44,11 @@ cd nomad-driver-podman
 - Linux host with `podman` installed
 - For rootless containers you need a system supporting cgroup V2 and a few other things, follow [this tutorial](https://github.com/containers/libpod/blob/master/docs/tutorials/rootless_tutorial.md)
 
-You need a varlink enabled podman binary and a system socket activation unit,
-see https://podman.io/blogs/2019/01/16/podman-varlink.html.
+You need a 2.x podman binary and a system socket activation unit,
+see https://www.redhat.com/sysadmin/podmans-new-rest-api
 
 nomad agent, nomad-driver-podman and podman will reside on the same host, so you
-do not have to worry about the ssh aspects of podman varlink.
+do not have to worry about the ssh aspects of the podman api.
 
 Ensure that nomad can find the plugin, see [plugin_dir](https://www.nomadproject.io/docs/configuration/index.html#plugin_dir)
 
@@ -334,22 +334,16 @@ GRUB_CMDLINE_LINUX_DEFAULT="quiet cgroup_enable=memory swapaccount=1 systemd.uni
 
 `sudo update-grub`
 
-ensure that podman varlink is running
-```
-$ systemctl --user status io.podman
-● io.podman.service - Podman Remote API Service
-     Loaded: loaded (/usr/lib/systemd/user/io.podman.service; disabled; vendor preset: enabled)
-     Active: active (running) since Wed 2020-07-01 16:01:41 EDT; 7s ago
-TriggeredBy: ● io.podman.socket
-       Docs: man:podman-varlink(1)
-   Main PID: 25091 (podman)
-      Tasks: 29 (limit: 18808)
-     Memory: 17.5M
-        CPU: 184ms
-     CGroup: /user.slice/user-1000.slice/[email protected]/io.podman.service
-             ├─25091 /usr/bin/podman varlink unix:/run/user/1000/podman/io.podman --timeout=60000 --cgroup-manager=systemd
-             ├─25121 /usr/bin/podman varlink unix:/run/user/1000/podman/io.podman --timeout=60000 --cgroup-manager=systemd
-             └─25125 /usr/bin/podman
+ensure that podman socket is running
+```
+$ systemctl --user status podman.socket
+* podman.socket - Podman API Socket
+     Loaded: loaded (/usr/lib/systemd/user/podman.socket; disabled; vendor preset: disabled)
+     Active: active (listening) since Sat 2020-10-31 19:21:29 CET; 22h ago
+   Triggers: * podman.service
+       Docs: man:podman-system-service(1)
+     Listen: /run/user/1000/podman/podman.sock (Stream)
+     CGroup: /user.slice/user-1000.slice/[email protected]/podman.socket             
 ```
 
 ensure that you have a recent version of [crun](https://github.com/containers/crun/)

api/api.go

@@ -0,0 +1,93 @@
+/*
+This Source Code Form is subject to the terms of the Mozilla Public
+License, v. 2.0. If a copy of the MPL was not distributed with this
+file, You can obtain one at https://mozilla.org/MPL/2.0/.
+*/
+
+package api
+
+import (
+	"context"
+	"fmt"
+	"io"
+	"net"
+	"net/http"
+	"os"
+	"strings"
+	"time"
+
+	"github.com/hashicorp/go-hclog"
+)
+
+type API struct {
+	baseUrl    string
+	httpClient *http.Client
+	logger     hclog.Logger
+}
+
+func NewClient(logger hclog.Logger) *API {
+	ac := &API{
+		logger: logger,
+	}
+	ac.SetSocketPath(DefaultSocketPath())
+	return ac
+}
+
+func (c *API) SetSocketPath(baseUrl string) {
+	c.logger.Debug("http baseurl", "url", baseUrl)
+	c.httpClient = &http.Client{
+		Timeout: 60 * time.Second,
+	}
+	if strings.HasPrefix(baseUrl, "unix:") {
+		c.baseUrl = "http://u"
+		path := strings.TrimPrefix(baseUrl, "unix:")
+		c.httpClient.Transport = &http.Transport{
+			DialContext: func(_ context.Context, _, _ string) (net.Conn, error) {
+				return net.Dial("unix", path)
+			},
+		}
+	} else {
+		c.baseUrl = baseUrl
+	}
+}
+
+// DefaultSocketPath returns the default unix domain socket path for root or non-root users
+func DefaultSocketPath() string {
+	uid := os.Getuid()
+	// are we root?
+	if uid == 0 {
+		return "unix:/run/podman/podman.sock"
+	}
+	// not? then let's try the default per-user socket location
+	return fmt.Sprintf("unix:/run/user/%d/podman/podman.sock", uid)
+}
+
+func (c *API) Do(req *http.Request) (*http.Response, error) {
+	res, err := c.httpClient.Do(req)
+	return res, err
+}
+
+func (c *API) Get(ctx context.Context, path string) (*http.Response, error) {
+	req, err := http.NewRequestWithContext(ctx, "GET", c.baseUrl+path, nil)
+	if err != nil {
+		return nil, err
+	}
+	return c.Do(req)
+}
+
+func (c *API) Post(ctx context.Context, path string, body io.Reader) (*http.Response, error) {
+	req, err := http.NewRequestWithContext(ctx, "POST", c.baseUrl+path, body)
+	if err != nil {
+		return nil, err
+	}
+	req.Header.Set("Content-Type", "application/json")
+	return c.Do(req)
+}
+
+func (c *API) Delete(ctx context.Context, path string) (*http.Response, error) {
+	req, err := http.NewRequestWithContext(ctx, "DELETE", c.baseUrl+path, nil)
+	if err != nil {
+		return nil, err
+	}
+	return c.Do(req)
+}