Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: upgrade Go version to 1.23.3 #395

Merged
merged 5 commits into from
Dec 2, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .go-version
Original file line number Diff line number Diff line change
@@ -1 +1 @@
1.21.6
1.23.3
1 change: 0 additions & 1 deletion .golangci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,6 @@ linters:
- unconvert
- gofmt
- gosimple
- depguard
- staticcheck
- asasalint
- asciicheck
Expand Down
4 changes: 2 additions & 2 deletions GNUmakefile
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,8 @@ hclfmt: ## Format HCL files with hclfmt
.PHONY: deps
deps: ## Install build dependencies
@echo "==> Installing build dependencies ..."
go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.52.2
go install github.com/hashicorp/go-hclog/hclogvet@v0.1.6
go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.62.2
go install github.com/hashicorp/go-hclog/hclogvet@v0.2.0
go install gotest.tools/[email protected]
go install github.com/hashicorp/hcl/v2/cmd/hclfmt@d0c4fa8b0bbc2e4eeccd1ed2a32c2089ed8c5cf1

Expand Down
2 changes: 1 addition & 1 deletion driver_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -1060,7 +1060,7 @@ func TestPodmanDriver_Init(t *testing.T) {
versionChange, _ := version.NewVersion("4.2")
parsedApiVersion, err := version.NewVersion(apiVersion)
if err != nil {
t.Fatalf(fmt.Sprintf("Not a valid version: %s", apiVersion))
t.Fatalf("Not a valid version: %s", apiVersion)
}

if parsedApiVersion.LessThan(versionChange) {
Expand Down
2 changes: 1 addition & 1 deletion go.mod
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/hashicorp/nomad-driver-podman

go 1.22.6
go 1.23.3

replace (
// Fix error tidying due to Nomad downstream dependencies and the recent
Expand Down
2 changes: 1 addition & 1 deletion handle.go
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,7 @@ func (h *TaskHandle) runContainerMonitor() {
} else {
h.exitResult.ExitCode = int(inspectData.State.ExitCode)
if len(inspectData.State.Error) > 0 {
h.exitResult.Err = fmt.Errorf(inspectData.State.Error)
h.exitResult.Err = errors.New(inspectData.State.Error)
h.logger.Error("Container error", "container", h.containerID, "error", h.exitResult.Err)
}
h.completedAt = inspectData.State.FinishedAt
Expand Down