Code

Support for multiple podman sockets#371

Code

Merged

tgross merged 28 commits intohashicorp:mainhashicorp/nomad-driver-podman:mainfrom adriaandens:rootless_podmanadriaandens/nomad-driver-podman:rootless_podmanCopy head branch name to clipboardOct 3, 2024

+584-252

Commits

Commits on Jul 23, 2024

• Changed specs to allow multiple sockets to be defined in driver and some other small debugging work

  adriaandens

  committed
  4248cc2

  Copy full SHA for 4248cc2

Commits on Jul 24, 2024

• Remove slowPodman because it does not use the http without timeout from the api instance

  adriaandens

  committed
  db5814d

  Copy full SHA for db5814d

• Made a map of all podmanClients

  adriaandens

  committed
  69a6013

  Copy full SHA for 69a6013

• Implement a guarantee to always have a default podman client

  adriaandens

  committed
  a416ca0

  Copy full SHA for a416ca0

• Change all references to d.podman to (hopefully) the 'correct' podman client

  adriaandens

  committed
  e16244d

  Copy full SHA for e16244d

• remove silly debug

  adriaandens

  committed
  4f0ac7a

  Copy full SHA for 4f0ac7a

• remove unused dep after removing silly debug

  adriaandens

  committed
  c7378bf

  Copy full SHA for c7378bf

• More cleanup

  adriaandens

  committed
  fe75abb

  Copy full SHA for fe75abb

Commits on Jul 28, 2024

• Tests directly call DefaultClientConfig and so we need to be aware about the socket we're gonna return

  adriaandens

  committed
  7878e9b

  Copy full SHA for 7878e9b

• Make all tests pass

  adriaandens

  committed
  5d318ab

  Copy full SHA for 5d318ab

Commits on Sep 28, 2024

• Instead of iterating over all podman sockets to find the container, use the Socket name in the TaskConfig to directly use the correct podman client

  adriaandens

  committed
  75f55c5

  Copy full SHA for 75f55c5

• Redone the fingerprinting to give a more accurate status, moved certain variables (rootless, cgroup) from driver to podman API because they're podman API dependent (root needs rootless=false, ...)

  adriaandens

  committed
  697569d

  Copy full SHA for 697569d

Commits on Sep 29, 2024

• Omit HostUser (it was not used anywhere), align naming/default behaviour of sockets to be more 'nomad'-like

  adriaandens

  committed
  b9a22f0

  Copy full SHA for b9a22f0

• Cleaning up, renaming some variables and strings to be more clear

  adriaandens

  committed
  9f46ba8

  Copy full SHA for 9f46ba8

• bugfix: if no socket was defined or if using the old socket_path -> use the default socket

  adriaandens

  committed
  b83b177

  Copy full SHA for b83b177

• Make tests pass, expose AppArmor (only used in tests)

  adriaandens

  committed
  a15526a

  Copy full SHA for a15526a

Commits on Oct 1, 2024

• Update README, changelog, and add an example

  adriaandens

  committed
  a43aede

  Copy full SHA for a43aede

• Implement requested changes

  adriaandens

  committed
  d117bee

  Copy full SHA for d117bee

• update file rights

  adriaandens

  committed
  f0ca64a

  Copy full SHA for f0ca64a

• fix permissions

  adriaandens

  committed
  6352638

  Copy full SHA for 6352638

• hclfmt on modified HCL files

  adriaandens

  committed
  e0fc0da

  Copy full SHA for e0fc0da

• Apply suggestions from code review

  Show description for f8c228f
  

  adriaandens

  and

  tgross

  authored
  f8c228f

  Copy full SHA for f8c228f

• Need to make a habit of running gofmt

  adriaandens

  committed
  125b276

  Copy full SHA for 125b276

Commits on Oct 2, 2024

• The correct init process is dependent on the Podman version. Starting from 4.2 the docs mention /run/podman-init: https://docs.podman.io/en/v4.2/markdown/podman-run.1.html

  adriaandens

  committed
  bd608db

  Copy full SHA for bd608db

• chmod change

  adriaandens

  committed
  c2e5d05

  Copy full SHA for c2e5d05

• Forgot to use the declared variable with the API version

  adriaandens

  committed
  6912c52

  Copy full SHA for 6912c52

• chmod change

  adriaandens

  committed
  d12cd80

  Copy full SHA for d12cd80

• Use HTTP Stream Client if context has a higher Deadline than our timeout (fixes Image_Pull_Timeout test)

  adriaandens

  committed
  3bd22ca

  Copy full SHA for 3bd22ca