Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: disable CGO for CRT release #367

Merged
merged 3 commits into from
Jul 15, 2024
Merged

build: disable CGO for CRT release #367

merged 3 commits into from
Jul 15, 2024

Conversation

pkazmierczak
Copy link
Contributor

@pkazmierczak pkazmierczak commented Jul 15, 2024 •
edited
Loading

Fixes #366

@pkazmierczak pkazmierczak requested review from shoenig and tgross July 15, 2024 13:34
@pkazmierczak pkazmierczak requested a review from a team as a code owner July 15, 2024 13:34
tgross
tgross approved these changes Jul 15, 2024
View reviewed changes
Copy link
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

GNUmakefile Show resolved Hide resolved
@pkazmierczak pkazmierczak merged commit a45fa59 into main Jul 15, 2024
6 of 7 checks passed
@pkazmierczak pkazmierczak deleted the disable-cgo branch July 15, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgross tgross tgross approved these changes

@shoenig shoenig Awaiting requested review from shoenig

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Version 0.6.0 breaks on EL8
2 participants
@pkazmierczak @tgross