-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow set global dns servers from client plugin config for contains #304
feat: allow set global dns servers from client plugin config for contains #304
Conversation
Why would you want to set this in the plugin section of the nomad config when you can just set DNS via https://developer.hashicorp.com/nomad/docs/job-specification/network#dns-1 in the networking block of the job? |
Do you think I am unaware of this configuration option? No, I am not. the arch is:
yes, I also have CNI network and uses flannel network fabric, so different nomad node machine can commuicate with each other via the cluster network. |
config.go
Outdated
ExtraLabels []string `codec:"extra_labels"` | ||
DNSServers []string `codec:"dns_servers"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needs to be go-fmt'd
The docker task driver also already has a |
Also @ttys3 if you don't mind rebasing on main; there's some CI fixes in there to help getting tests working again. |
No need to get defensive. Your original PR had zero details on why this was needed and I was simply asking to better understand your use-case and the reason for the PR. Thank you for taking the time to explain why. I appreciate it. |
Sorry my previous reply was a bit unkind. I take back what I said before. |
```hcl plugin "nomad-driver-podman" { config { dns_servers = ["192.168.8.100"] } } ```
e9d37f1
to
ec1dcdd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM; thanks @ttys3!
so we can config dns for containers like: