Adjust ContainerStats for Podmod 4.6.0 responses

[sushain97]

Fixes #277

[hashicorp-cla]

All committers have signed the CLA.

[Procsiab]

I can report that this PR fixes #277 in my environment, on both x86_64 and aarch64 Nomad 1.6.1 clients with Podman 4.6.0-1. Thanks for your quick response @sushain97 💪

[shoenig]

@sushain97 check the linter failure

==> Linting source code ...
Error: api/container_stats.go:52:5: shadow: declaration of "err" shadows declaration at line 22 (govet)
	if err := json.Unmarshal(body, &errResponse); err == nil && errResponse.Cause == "container is stopped" {
	   ^
make: *** [GNUmakefile:32: check] Error 1

[sushain97]

@shoenig fixed

[sushain97]

@lgfa29 does this look good?

[lgfa29]

This looks good to me, thanks for the PR @sushain97!

I'm deferring the final merge to @shoenig since he's been working more closely with the Podman driver more recently

[shoenig]

@sushain97 I think your fix has a compilation bug:

if _ := json.Unmarshal(body, &errResponse); ...{

needs to be

if _ = json.Unmarshal(body, &errResponse); ... {

[sushain97]

@shoenig fixed - the suggestion wasn't quite right.

Would be helpful to have workflows approved for the entire branch/PR :)

[shoenig]

LGTM; thanks @sushain97 !

[sushain97]

No problem! Would it be possible to cut a 0.5.1 release with this fix?