-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
driver: set cpuset when using cgroups v2 #252
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR makes it so that the Podman driver will now respect the task config resources.cores value. When set, the task will be assigned the specified number of CPU cores to be allowed to run on. Note: unlike the docker/exec drivers, podman tasks will not be also allowed to make use of the "shared" set of cpu cores (ones that have not yet been reserved specifically for a task). Most likely that feature will be removed in the near future (~Nomad 1.7) anyway.
Spot check, just run a job with some basic jobjob "sleep" {
group "group" {
count = 4
task "sleep" {
driver = "podman"
config {
image = "docker.io/bash:5"
args = ["sleep", "infinity"]
}
resources {
cores = 2
memory = 64
}
}
}
} inspecting cpusets, each is assigned 2 cores
|
jrasell
approved these changes
Jun 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it so that the Podman driver will now respect the task
config
resources.cores
value. When set, the task will be assigned thespecified number of CPU cores to be allowed to run on.
Note: unlike the docker/exec drivers, podman tasks will not be also allowed
to make use of the "shared" set of cpu cores (ones that have not yet been
reserved specifically for a task). Most likely that feature will be removed
in the near future (~Nomad 1.7) anyway.
Closes #160