Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect telemetry.collection_interval to reduce cpu churn when running many containers #130

Merged
merged 1 commit into from
Aug 11, 2021

Conversation

towe75
Copy link
Collaborator

@towe75 towe75 commented Aug 9, 2021

Use telemetry.collection_interval for each container monitor. Previously we polled for each container with a very fast, static, 1 second interval. This does not scale very well and we can see a considerable load on the podman service when running e.g. a job with 30 pause containers.

Copy link
Contributor

@lgfa29 lgfa29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Minor question about storing the need to store the interval, but definitely not a blocker.

handle.go Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@towe75 towe75 force-pushed the f_collection_interval branch from 50b0f8c to dc22a4b Compare August 11, 2021 18:45
@towe75 towe75 merged commit 057d0c4 into main Aug 11, 2021
@towe75 towe75 deleted the f_collection_interval branch August 11, 2021 18:54
@ttys3
Copy link
Contributor

ttys3 commented Aug 22, 2021

before this I found my podman socket daemon flooded by health check log.

I have to increase podman log level to error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants