Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: map host devices into container #129

Merged
merged 3 commits into from
Aug 4, 2021
Merged

config: map host devices into container #129

merged 3 commits into from
Aug 4, 2021

Conversation

towe75
Copy link
Collaborator

@towe75 towe75 commented Jul 11, 2021

Fixes #41

@towe75 towe75 removed request for lgfa29 and jazzyfresh July 11, 2021 10:48
driver.go Outdated Show resolved Hide resolved
@towe75 towe75 requested a review from jrasell July 24, 2021 12:47
@towe75
Copy link
Collaborator Author

towe75 commented Aug 4, 2021

@jrasell : can we merge?

Copy link
Member

@jrasell jrasell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, sorry for the delay @towe75!

@towe75 towe75 merged commit 57a9efe into main Aug 4, 2021
@towe75 towe75 deleted the f_device branch August 4, 2021 17:59
@kriansa
Copy link

kriansa commented Sep 28, 2021

@towe75 How can we update https://www.nomadproject.io/docs/drivers/podman to match the info that this is now supported?

@lgfa29
Copy link
Contributor

lgfa29 commented Oct 12, 2021

@kriansa hashicorp/nomad#11300 will update the documentation in Nomad website 👍

@jeefberkey
Copy link

jeefberkey commented Jan 13, 2022

This feature is in the documentation now, but not available in a released version of the software. Can there be a new release containing this feature?

@towe75
Copy link
Collaborator Author

towe75 commented Jan 13, 2022

@lgfa29 there are a few other branches ready. Maybe you can find the time to cut a release?

@lgfa29
Copy link
Contributor

lgfa29 commented Jan 13, 2022

Sure, I can cut a release when you're ready.

Do you need help reviewing some of the open PRs? These seem like good candidates to include in the release:
#133
#139
#149

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support devices
5 participants