config: minor fixes on driver logging config

Since `nomad` is the default value for `Driver` users may be able to
specify just `Options` in the task `config`, so we need to check if no
value are set.

CHANGELOG.md

@@ -2,7 +2,8 @@
 
 IMPROVEMENTS:
 
- * build: Updated to Go 1.21.5 [[GH-303](https://github.com/hashicorp/nomad-driver-podman/pull/303)] 
+ * build: Updated to Go 1.21.5 [[GH-303](https://github.com/hashicorp/nomad-driver-podman/pull/303)]
+ * config: Add `logging` options to the plugin configuration [[GH-285](https://github.com/hashicorp/nomad-driver-podman/pull/285)]
 
 ## 0.5.1 (August 14, 2023)
 

config.go

@@ -146,6 +146,11 @@ type TaskLoggingConfig struct {
 	Options hclutils.MapStrStr `codec:"options"`
 }
 
+// Empty returns true if the logging configuration is not set.
+func (l *TaskLoggingConfig) Empty() bool {
+	return l.Driver == "" && len(l.Options) == 0
+}
+
 // VolumeConfig is the drivers volume specific configuration
 type VolumeConfig struct {
 	Enabled      bool   `codec:"enabled"`

driver.go

@@ -502,9 +502,9 @@ func (d *Driver) StartTask(cfg *drivers.TaskConfig) (*drivers.TaskHandle, *drive
 	createOpts.ContainerBasicConfig.Labels = driverConfig.Labels
 
 	// Logging
-	if driverConfig.Logging.Driver != "" {
+	if !driverConfig.Logging.Empty() {
 		switch driverConfig.Logging.Driver {
-		case LOG_DRIVER_NOMAD:
+		case "", LOG_DRIVER_NOMAD:
 			if !d.config.DisableLogCollection {
 				createOpts.LogConfiguration.Driver = "k8s-file"
 				createOpts.ContainerBasicConfig.LogConfiguration.Path = cfg.StdoutPath
@@ -518,9 +518,7 @@ func (d *Driver) StartTask(cfg *drivers.TaskConfig) (*drivers.TaskHandle, *drive
 	} else {
 		d.logger.Trace("no podman log driver provided, defaulting to plugin config")
 		switch d.config.Logging.Driver {
-		case "": // The default is nomad
-			fallthrough
-		case LOG_DRIVER_NOMAD:
+		case "", LOG_DRIVER_NOMAD:
 			if !d.config.DisableLogCollection {
 				createOpts.LogConfiguration.Driver = "k8s-file"
 				createOpts.ContainerBasicConfig.LogConfiguration.Path = cfg.StdoutPath