add max_scale_up and max_scale_down for pass-through #881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brmzkw
requested review from
jrasell,
Juanadelacuesta and
lgfa29
as code owners
This is similar to a4e70bc.
brmzkw
force-pushed
the
jcastets/passthrough-max-scale-up-down
branch
from
7568ca1 to
8cf452d
Compare
|
hey @lgfa29, do you think you can give a look to this PR? |
|
up :) |
lgfa29
approved these changes
Apr 4, 2024
There was a problem hiding this comment.
Hi @brmzkw, apologies for the delay here. Everything looks good, thanks for the PR!
Would you be able to add the new configuration values to the Nomad documentation as well?
https://github.com/hashicorp/nomad/blob/main/website/content/tools/autoscaling/plugins/strategy/pass-through.mdx
|
Great! thanks a lot! Yes, I'll add the documentation too |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is similar to a4e70bc.