Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Azure VMSS target plugin #278

Merged
merged 6 commits into from
Oct 25, 2020

Conversation

lcheruka
Copy link
Contributor

@lcheruka lcheruka commented Oct 2, 2020

No description provided.

@jrasell
Copy link
Member

jrasell commented Oct 6, 2020

@lcheruka thanks so much for this! It may take a little time to get this properly tested, but i'll keep you updated as its worked through.

@lgfa29 lgfa29 force-pushed the f-azure-vmss-cluster-scaling branch from a703dc4 to b128b2a Compare October 25, 2020 19:39
@lgfa29
Copy link
Contributor

lgfa29 commented Oct 25, 2020

Thank you so much for the contribution @lcheruka!

Sorry it took this long for us to review, but we were quite busy with Nomad 1.0 and we also had to ramp-up our knowledge of Azure in order to properly test this.

I made small changes to the PR to:

  1. automatically load the plugin in the agent
  2. fallback to looking for the instance name using node meta tags since Azure fingerprinting is not released in Nomad yet, and this would also allow clusters pre-Nomad 1.0 to use this as well (although they would need to manually add the meta tag to their clients)

I also rebased the branch to pickup and fix the import path for the helper module, since we moved to sdk/helper.

There's a WIP PR that will deploy a demo cluster. It's just pending the new release of the Nomad and Nomad Autoscaler, but if you have any feedback we would appreciate as well.

@lgfa29 lgfa29 merged commit 14b927b into hashicorp:master Oct 25, 2020
jrasell added a commit that referenced this pull request Oct 26, 2020
cgbaker added a commit that referenced this pull request Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants