Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use golang.org/x/net? #37

Closed
wants to merge 1 commit into from
Closed

use golang.org/x/net? #37

wants to merge 1 commit into from

Conversation

cryptix
Copy link

@cryptix cryptix commented Apr 28, 2015

Can you explain why you maintain a fork of the old go.net repo at hashicorp? I saw that it still imports code from code.google.com.

github.com/hashicorp/go.net/ipv4/control_bsd.go:    "code.google.com/p/go.net/internal/iana"
github.com/hashicorp/go.net/ipv4/control_pktinfo.go:    "code.google.com/p/go.net/internal/iana"
github.com/hashicorp/go.net/ipv4/control_unix.go:   "code.google.com/p/go.net/internal/iana"
github.com/hashicorp/go.net/ipv4/example_test.go:   "code.google.com/p/go.net/internal/iana"
github.com/hashicorp/go.net/ipv4/multicast_test.go: "code.google.com/p/go.net/internal/iana"
github.com/hashicorp/go.net/ipv4/sockopt_asmreq_unix.go:    "code.google.com/p/go.net/internal/iana"
github.com/hashicorp/go.net/ipv4/sockopt_asmreq_windows.go: "code.google.com/p/go.net/internal/iana"
github.com/hashicorp/go.net/ipv4/sockopt_asmreqn_unix.go:   "code.google.com/p/go.net/internal/iana"
github.com/hashicorp/go.net/ipv4/sockopt_unix.go:   "code.google.com/p/go.net/internal/iana"
github.com/hashicorp/go.net/ipv4/sockopt_windows.go:    "code.google.com/p/go.net/internal/iana"
github.com/hashicorp/go.net/ipv4/unicast_test.go:   "code.google.com/p/go.net/internal/iana"
github.com/hashicorp/go.net/ipv4/unicastsockopt_test.go:    "code.google.com/p/go.net/internal/iana"

The original Issue for the fork is closed as far as I can tell.

Instead of updating the fork, I'd like to short circuit it here and just use the new upstream location of it.

@cryptix cryptix mentioned this pull request Apr 28, 2015
6 tasks
@ryanuber
Copy link
Member

Hey @cryptix,

The reason for the fork is this comment. Since we haven't yet adopted a great solution for pinning an external Go library to a specific commit, we can't afford to have a few days of build failures every time the upstream library makes a breaking change, which they suggest will happen from time to time. We are in the process of adopting a practice to handle this kind of thing, so the fork should go away some time soon, but we aren't quite there yet.

I'm going to close this for now, but we are aware of the issue and have a plan going forward. Thanks!

@ryanuber ryanuber closed this May 31, 2015
@cryptix cryptix deleted the golangOrgX branch October 26, 2015 10:16
This was referenced Oct 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants