Fix default browser boolean semantics #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dadgar
approved these changes
Aug 27, 2024
ohm
force-pushed
the
ohm/fix-default-browser-boolean
branch
2 times, most recently
from
aeff42f to
a82084c
Compare
dadgar
approved these changes
Aug 28, 2024
ohm
force-pushed
the
ohm/fix-default-browser-boolean
branch
from
bc371e3 to
c3e095d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠️ Description
By default we should be opening the default browser.
This fixes a mistake introduced in #265 which inverts the expected behavior.
🔗 External Links
👍 Definition of Done