Code

golangci-lint workflow#262

Code

Merged

uturunku1 merged 19 commits intomainhashicorp/go-tfe:mainfrom add-golangcilinthashicorp/go-tfe:add-golangcilintCopy head branch name to clipboardSep 29, 2021

+117-54

Commits

Commits on Sep 22, 2021

• draft golangci-lint workflow

  uturunku1

  committed
  3dd8ec4

• fix gh action error that says every step must define a or key

  uturunku1

  committed
  222fe15

• 1.42.1 is an invalid version

  uturunku1

  committed
  e8279f2

• temporarily commenting the option only-new-issues to correct old issues

  uturunku1

  committed
  6bfaa45

• apply golangci-lint recommendations: remove unused code which is everything that was inside helper_test.go and remove unnecesary use of formatting

  uturunku1

  committed
  e14e068

• add back file because its functions are being used, is just that golangci-lint does not see it

  uturunku1

  committed
  08332ca

• add flag to ignore test files

  uturunku1

  committed
  9f58003

Commits on Sep 23, 2021

• add yml for golangci configuration and add setting to ignore unused functions from test files

  uturunku1

  committed
  5b21f13

Commits on Sep 28, 2021

• remove extra lines

  uturunku1

  committed
  13c20e5

• pin to version 1.29 to compare behaviour with version 1.40

  uturunku1

  committed
  413f623

• enable some useful lint libraries and use go version 1.16 and golangci-lint 1.42 to match local environment

  uturunku1

  committed
  3c44683

• golangci-lint library recommends to stop using golint because it is deprecated and archive, and instead use revive: https://github.com/hashicorp/go-tfe/pull/262/checks?check_run_id=3738237150

  uturunku1

  committed
  be0ed9d

• fix new issues point by golangci-lint

  uturunku1

  committed
  771ab13

• clarify comment on why we are not using golint

  uturunku1

  committed
  cabf350

Commits on Sep 29, 2021

• enable other lint libraries that I liked their description and add additional configuration to errcheck because some of their features are disable by default

  uturunku1

  committed
  1689acd

• add configuration to golangci-lint and fix errors mentioned by enabled lint libraries

  uturunku1

  committed
  a573060

• remove not useful comments

  uturunku1

  committed
  2e17d84

• match lowercase in tests

  uturunku1

  committed
  1cb63d4

• missing test

  uturunku1

  committed
  8b80493