Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump jsonapi, update RunTrigger use deprecated relation #1027

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

notchairmk
Copy link
Member

Description

Prerequisite for #1016.

Bumps the jsonapi version to address a bug with interactions between polyrelation and deprecated relation.

Updates run triggers to backfill the deprecated Sourceable field in the RunTrigger struct.

Testing plan

External links

Output from tests

Including output from tests may require access to a TFE instance. Ignore this section if you have no environment to test against.

$ TFE_ADDRESS="https://example" TFE_TOKEN="example" go test ./... -v -run TestFunctionsAffectedByChange

...

@notchairmk notchairmk requested a review from a team as a code owner January 7, 2025 19:47
@datadog-terraform-cloud-hashicorp

Datadog Report

Branch report: update-jsonapi-dep
Commit report: 4d8129b
Test service: hashicorp/go-tfe

✅ 0 Failed, 1419 Passed, 155 Skipped, 20m 3.14s Total Time
➡️ Test Sessions change in coverage: 1 no change

@notchairmk notchairmk merged commit f215e07 into main Jan 7, 2025
8 checks passed
@notchairmk notchairmk deleted the update-jsonapi-dep branch January 7, 2025 21:22
Copy link

github-actions bot commented Jan 7, 2025

Reminder to the contributor that merged this PR: if your changes have added important functionality or fixed a relevant bug, open a follow-up PR to update CHANGELOG.md with a note on your changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants