support HTTPDate in Retry-After header #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
justenwalker
force-pushed
the
support-retryafter-date
branch
from
ea16331 to
2cbfe34
Compare
According to [RFC7231](https://httpwg.org/specs/rfc7231.html#header.retry-after) the Retry-After header may be specified in both number of seconds OR an HTTPDate > The value of this field can be either an HTTP-date or a number of seconds to delay after the response is received. > > Retry-After = HTTP-date / delay-seconds > > A delay-seconds value is a non-negative decimal integer, representing time in seconds. > > delay-seconds = 1*DIGIT > > Two examples of its use are > > Retry-After: Fri, 31 Dec 1999 23:59:59 GMT > Retry-After: 120 This change adds support for parsing the date if the format of the header contains non-numeric characters
justenwalker
force-pushed
the
support-retryafter-date
branch
from
2cbfe34 to
e16f958
Compare
justenwalker
force-pushed
the
support-retryafter-date
branch
from
8b0038a to
badefbb
Compare
Removes dependency on regular expressions for detecting numeric header values vs date values
justenwalker
force-pushed
the
support-retryafter-date
branch
from
badefbb to
f2396f0
Compare
|
Hi, I have seen a few pull requests like this that are updated whenever the last pull request have conflicts with current version. Can Hashicorp add this functionality, please? |
|
I opened #144 for discussion about the feature. Given that there are now 3 PRs that accomplish the same thing, we should probably consolidate discussion in a single place. |
manicminer
approved these changes
May 9, 2024
There was a problem hiding this comment.
@justenwalker Thanks for submitting this PR! Although there are a few open PRs aiming to add this functionality, this feels like the cleanest and most robust implementation. As such I'll merge this for inclusion in an upcoming release. Thanks again.
manicminer
added a commit
that referenced
this pull request
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to RFC7231
the Retry-After header may be specified in both number of seconds OR an HTTPDate
This change adds support for parsing the date if the format of the header contains non-numeric characters
Closes: #144