Honor TimeNotBuiltin #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was running some tests elsewhere, and noticed that the `BasicHandle.TimeNotBuiltin` option was not being honored by `MsgpackHandle`. This option is critical for maintaining backwards compatibility in certain cases, notably some of our Raft usage. I added a test here to ensure that the option works. While we're here, I updated `go.mod` and `go.sum`, since I'll probably cut the 2.1.1 release after this.
|
(format check is mostly the result of auto-generated and docs code, and not relevant to this PR, but I can fix later) |
tomhjp
approved these changes
Oct 17, 2023
go.mod
Outdated
| @@ -1,15 +1,15 @@ | |||
| module github.com/hashicorp/go-msgpack/v2 | |||
|
|
|||
| go 1.19 | |||
| go 1.20 | |||
There was a problem hiding this comment.
nit: are there any specific benefits we needed from bumping the minimum Go version? I would tend slightly towards leaving it for libraries unless we need to bump it - just to make it as easy as possible for dependents to upgrade, but I'm also not hugely opposed to bumping it.
There was a problem hiding this comment.
Cool, I can un-bump that. It doesn't really do much until 1.21.
| @@ -286,6 +286,15 @@ func (e *msgpackEncDriver) EncodeFloat64(f float64) { | |||
| } | |||
|
|
|||
| func (e *msgpackEncDriver) EncodeTime(t time.Time) { | |||
| // use the MarshalBinary format if requested | |||
| if e.h.TimeNotBuiltin { | |||
There was a problem hiding this comment.
IIUC correctly we don't need to concern ourselves with this setting in the decode function because it handles both cases seamlessly right?
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was running some tests elsewhere, and noticed that the
BasicHandle.TimeNotBuiltinoption was not being honored byMsgpackHandle. This option is critical for maintaining backwards compatibility in certain cases, notably some of our Raft usage.I added a test here to ensure that the option works.
While we're here, I updated
go.modandgo.sum, since I'll probably cut the 2.1.1 release after this.