Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix benchmarks; delete cbor, simple, binc #17

Merged
merged 1 commit into from
Dec 9, 2022
Merged

Fix benchmarks; delete cbor, simple, binc #17

merged 1 commit into from
Dec 9, 2022

Conversation

swenson
Copy link

@swenson swenson commented Dec 7, 2022 •
edited
Loading

  • Fixed all of the benchmark code to work again.
  • Updated documentation with correct package paths
  • Deleted protocols we don't need
    • cbor
    • simple
    • binc
  • Removed a bunch of workarounds for old Go versions
  • Removed some redundant documentation

Fix benchmarks; delete cbor, simple, binc
c5d3acb 
* Fixed all of the benchmark code to work again.
* Updated documentation with correct package paths
* Deleted protocols we don't need
   cbor
   * simple
   * binc
* Removed a bunch of workarounds for old Go versions
* Removed some redundant documentation
@swenson swenson requested review from tomhjp and kisunji December 7, 2022 18:22
swenson
swenson commented Dec 7, 2022
View reviewed changes
codec/doc.go
@@ -2,38 +2,26 @@
// Use of this source code is governed by a MIT license found in the LICENSE file.

/*
Package codec provides a
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of these changes come from me copying the README.md into here to get them back in sync.

@swenson swenson requested review from kisunji and tomhjp and removed request for tomhjp and kisunji December 9, 2022 17:49
@swenson
Copy link
Author

swenson commented Dec 9, 2022

I think this wraps up most of what I wanted to get done. I'll cut a release of the v2 branch so people can see use it and perhaps upgrade.

Thanks! I appreciate all of the review @kisunji and @tomhjp

@swenson swenson merged commit c68e948 into main Dec 9, 2022
@swenson swenson deleted the fix-benchmarks-remove-more branch December 9, 2022 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kisunji kisunji kisunji approved these changes

@tomhjp tomhjp Awaiting requested review from tomhjp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@swenson @kisunji