prometheus: prevent panic when incrmenting counter #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lgfa29 as an alternative because this seems like such a weird case and a programmer error rather than a runtime error, what would you think about shipping a version of Nomad pinned to this branch to see if we can get reports on the error to fix the underlying cause? |
|
Ah good idea. I will open a PR with this dependency update on Nomad tomorrow. I will probably rebase this as branch to |
The Prometheus Counter.Add() method panics if the value being added is negative. Even if care is taken by consumers to never pass a negative value the panic could still happen due to float conversion or overflow. This change prevents go-metrics from causing consumers to crash.
lgfa29
force-pushed
the
fix-prometheus-panic
branch
from
9c4352b to
d9ca9af
Compare
This was referenced May 11, 2023
Merged
Merged
banks
approved these changes
Nov 24, 2023
lgfa29
added a commit
to hashicorp/nomad
that referenced
this pull request
Nov 28, 2023
Update `go-metrics` to v0.5.3 to pick hashicorp/go-metrics#146.
lgfa29
added a commit
to hashicorp/nomad
that referenced
this pull request
Nov 28, 2023
Update `go-metrics` to v0.5.3 to pick hashicorp/go-metrics#146.
lgfa29
added a commit
to hashicorp/nomad
that referenced
this pull request
Nov 28, 2023
Update `go-metrics` to v0.5.3 to pick hashicorp/go-metrics#146.
lgfa29
added a commit
to hashicorp/nomad
that referenced
this pull request
Nov 28, 2023
Update `go-metrics` to v0.5.3 to pick hashicorp/go-metrics#146.
lgfa29
added a commit
to hashicorp/nomad
that referenced
this pull request
Nov 28, 2023
Update `go-metrics` to v0.5.3 to pick hashicorp/go-metrics#146.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Prometheus Counter.Add() method panics if the value being added is negative. Even if care is taken by consumers to never pass a negative value the panic could still happen due to float conversion or overflow.
This change prevents go-metrics from causing consumers to crash.
A panic like this has been reported in hashicorp/nomad#15861, but, as far as I can tell, Nomad only calls
IncrCounterandIncrCounterWithLabelsusing positive values.