Fix Go Tests for V2 #392
Merged
Fix Go Tests for V2 #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update test s3 bucket name let see if s3 tests work now try matrix for multiple directories try to fix GCS tests move go tests after GCS auth Revert "move go tests after GCS auth" This reverts commit 7adfd47. move go tests after GCS auth comment out other workflows go mod tidy go mod tidy comment out go cmd for now Revert "go mod tidy" This reverts commit 416722c. remove helper directory revert go mod add go cmd go mod tidy for GCS go mod tidy for cmd
claire-labry
force-pushed
the
fix-go-tests
branch
from
d630629 to
f4436ce
Compare
nywilken
approved these changes
Oct 27, 2022
gcs/get_gcs_test.go
Outdated
| } | ||
| return func() {} | ||
| } | ||
| // Note for external contributors: In order to run the GCS test suite, you will only be able to be run |
| @@ -9,11 +9,9 @@ replace ( | |||
| ) | |||
|
|
|||
| require ( | |||
| github.com/cheggaaa/pb v1.0.28 | |||
| github.com/fatih/color v1.9.0 // indirect | |||
| github.com/cheggaaa/pb v1.0.29 | |||
There was a problem hiding this comment.
Thanks for addressing. I have this change in the 1.18 PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Being new to this codebase, it was brought to my attention that the go-tests weren't properly testing the packages used (i.e.
gcsands3) This PR fixes that by adding s3, gcs, and top-level go-tests and they are being run properly now. Some of the changes to the s3 and gcs test files were borrowed from the updates that Security made in the main version of go-getter.