HttpGetter: Avoid reusing the same http.Request #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radeksimko
force-pushed
the
fix-req-race-condition
branch
2 times, most recently
from
466cd11 to
fa86e8e
Compare
radeksimko
force-pushed
the
fix-req-race-condition
branch
from
fa86e8e to
3cca945
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a race condition as demonstrated by the attached test.
go-cleanhttpis bumped to0.5.2as that brings this patch hashicorp/go-cleanhttp@6d9e2ac which in combination with the implementation introduces the race condition.See also golang/go#45311
This will effectively unblock hashicorp/terraform-ls#448 once
terraform-execupgradesgo-getterto a version with this patch.