Code

Getters refactoring#255

Code

Merged

sylviamoss merged 113 commits intov2hashicorp/go-getter:v2from getters_refactoringhashicorp/go-getter:getters_refactoringCopy head branch name to clipboardJun 4, 2020

+2,067-312

Commits

Commits on Mar 26, 2020

• Add SmbGetter

  sylviamoss

  committed
  527b5c1

  Copy full SHA for 527b5c1

Commits on Mar 27, 2020

• Validate smb path contains host and filepath, add tests

  sylviamoss

  committed
  1fd6e4d

  Copy full SHA for 1fd6e4d

• Fix format

  sylviamoss

  committed
  9fa2932

  Copy full SHA for 9fa2932

Commits on Apr 16, 2020

• Test circleci with samba server

  sylviamoss

  committed
  2931f37

  Copy full SHA for 2931f37

• fix circleci config.yml

  sylviamoss

  committed
  8663295

  Copy full SHA for 8663295

• fix circleci config.yml

  sylviamoss

  committed
  dc15b4c

  Copy full SHA for dc15b4c

• fix env on circleci config.yml

  sylviamoss

  committed
  6aec162

  Copy full SHA for 6aec162

• fix env on circleci config.yml

  sylviamoss

  committed
  dc7d1ce

  Copy full SHA for dc7d1ce

• fix circleci config.yml one more time

  sylviamoss

  committed
  7219a8e

  Copy full SHA for 7219a8e

• fix circleci config.yml at docker volume definition

  sylviamoss

  committed
  84b332e

  Copy full SHA for 84b332e

• fix circleci config.yml at docker volume definition

  sylviamoss

  committed
  e4c17c5

  Copy full SHA for e4c17c5

• fix circleci config.yml at docker volume definition

  sylviamoss

  committed
  04bbbaa

  Copy full SHA for 04bbbaa

• cd to go-getter before go mod

  sylviamoss

  committed
  95e4f30

  Copy full SHA for 95e4f30

• remove go mod

  sylviamoss

  committed
  5213d92

  Copy full SHA for 5213d92

• split smb test

  sylviamoss

  committed
  ce3e38e

  Copy full SHA for ce3e38e

• fix circleci config.yml

  sylviamoss

  committed
  ba4819d

  Copy full SHA for ba4819d

• remove logs and test docker exec

  sylviamoss

  committed
  80ad6b3

  Copy full SHA for 80ad6b3

• add working dir

  sylviamoss

  committed
  e6096b2

  Copy full SHA for e6096b2

• add testing docker cmd

  sylviamoss

  committed
  7fb5703

  Copy full SHA for 7fb5703

• Add docker compose

  sylviamoss

  committed
  446b379

  Copy full SHA for 446b379

• change golang image

  sylviamoss

  committed
  61404b9

  Copy full SHA for 61404b9

• add ls to circleci config

  sylviamoss

  committed
  6de5e77

  Copy full SHA for 6de5e77

• sakda

  sylviamoss

  committed
  315b03f

  Copy full SHA for 315b03f

• try 1

  sylviamoss

  committed
  89e52e9

  Copy full SHA for 89e52e9

• try 2

  sylviamoss

  committed
  b70d6cb

  Copy full SHA for b70d6cb

• try one more time

  sylviamoss

  committed
  65c6cd6

  Copy full SHA for 65c6cd6

• remove weird char

  sylviamoss

  committed
  03e65b3

  Copy full SHA for 03e65b3

• one last think

  sylviamoss

  committed
  baf26a9

  Copy full SHA for baf26a9

Commits on Apr 17, 2020

• run containers at the same time

  sylviamoss

  committed
  44f7ff8

  Copy full SHA for 44f7ff8

• skip smb tests when env var is not set

  sylviamoss

  committed
  4d3aa87

  Copy full SHA for 4d3aa87

• add failing test to see what happens

  sylviamoss

  committed
  8308b6e

  Copy full SHA for 8308b6e

• test smbclient

  sylviamoss

  committed
  24f6452

  Copy full SHA for 24f6452

• remove comment

  sylviamoss

  committed
  c31df12

  Copy full SHA for c31df12

• config back to normal

  sylviamoss

  committed
  2541772

  Copy full SHA for 2541772

• adds struct test and test cases

  sylviamoss

  committed
  95366d5

  Copy full SHA for 95366d5

• fmt and undo some unecessary changes

  sylviamoss

  committed
  42ad460

  Copy full SHA for 42ad460

• remove dst folder when created on smbclient

  sylviamoss

  committed
  1bb624b

  Copy full SHA for 1bb624b

Commits on Apr 20, 2020

• add GetFile tests

  sylviamoss

  committed
  64fb020

  Copy full SHA for 64fb020

• write smb mode

  sylviamoss

  committed
  679547a

  Copy full SHA for 679547a

• write smb mode tests

  sylviamoss

  committed
  9cecc40

  Copy full SHA for 9cecc40

• fix fmt

  sylviamoss

  committed
  116f648

  Copy full SHA for 116f648

• add mounted folder as test

  sylviamoss

  committed
  130a20e

  Copy full SHA for 130a20e

• remove pass from mount command

  sylviamoss

  committed
  76c6d38

  Copy full SHA for 76c6d38

• change mount sec type

  sylviamoss

  committed
  5d602d5

  Copy full SHA for 5d602d5

• change mount sec type

  sylviamoss

  committed
  625e7a1

  Copy full SHA for 625e7a1

• Try cleaning docker-compose

  sylviamoss

  committed
  e4fade8

  Copy full SHA for e4fade8

• Remove local mount tests and config

  sylviamoss

  committed
  a1c9f21

  Copy full SHA for a1c9f21

• try back mounting samba folder

  sylviamoss

  committed
  b426885

  Copy full SHA for b426885

• remove mount

  sylviamoss

  committed
  d3bdbe7

  Copy full SHA for d3bdbe7

Commits on Apr 21, 2020

• add makefile and write tests

  sylviamoss

  committed
  b2674f8

  Copy full SHA for b2674f8

• download dir with smbclient

  sylviamoss

  committed
  171bb46

  Copy full SHA for 171bb46

• update readme

  sylviamoss

  committed
  4e79911

  Copy full SHA for 4e79911

• write better ests names and update makefile

  sylviamoss

  committed
  42954ff

  Copy full SHA for 42954ff

• test smb authentication in private shared folder

  sylviamoss

  committed
  acc21a1

  Copy full SHA for acc21a1

• try to mount samba shared folder

  sylviamoss

  committed
  5fa9370

  Copy full SHA for 5fa9370

Commits on Apr 22, 2020

• use dockerfile instead

  sylviamoss

  committed
  33158fe

  Copy full SHA for 33158fe

• remove unecessary code from tests

  sylviamoss

  committed
  62a9f0a

  Copy full SHA for 62a9f0a

• fix destination path

  sylviamoss

  committed
  075c973

  Copy full SHA for 075c973

• improve error msg

  sylviamoss

  committed
  02a1857

  Copy full SHA for 02a1857

Commits on Apr 23, 2020

• Fix comment typo

  Show description for d670e78
  

  sylviamoss

  and

  SwampDragons

  authored
  d670e78

  Copy full SHA for d670e78

• Fix error msg typo

  Show description for 7f77866
  

  sylviamoss

  and

  SwampDragons

  authored
  7f77866

  Copy full SHA for 7f77866

• Fix comment typo

  Show description for de18f12
  

  sylviamoss

  and

  SwampDragons

  authored
  de18f12

  Copy full SHA for de18f12

• Fix comment typo

  Show description for 39c210b
  

  sylviamoss

  and

  SwampDragons

  authored
  39c210b

  Copy full SHA for 39c210b

• improve error messaging

  sylviamoss

  committed
  097b777

  Copy full SHA for 097b777

• update readme

  sylviamoss

  committed
  af77482

  Copy full SHA for af77482

• Merge branch 'add_smb_getter' of github.com:hashicorp/go-getter into add_smb_getter

  sylviamoss

  committed
  f9b00b7

  Copy full SHA for f9b00b7

• fix format

  sylviamoss

  committed
  b350351

  Copy full SHA for b350351

Commits on Apr 24, 2020

• Add smbdetector and client tests

  sylviamoss

  committed
  447c3f6

  Copy full SHA for 447c3f6

• Update readme

  sylviamoss

  committed
  e520fc4

  Copy full SHA for e520fc4

• remove testing log

  sylviamoss

  committed
  aaafb58

  Copy full SHA for aaafb58

Commits on Apr 27, 2020

• user smbclient command directly

  sylviamoss

  committed
  c326e24

  Copy full SHA for c326e24

• rename err variable

  sylviamoss

  committed
  337def6

  Copy full SHA for 337def6

• User filegetter only for windows when it's available

  sylviamoss

  committed
  0238bda

  Copy full SHA for 0238bda

• update readme

  sylviamoss

  committed
  ebf89a3

  Copy full SHA for ebf89a3

• fix comment description

  sylviamoss

  committed
  ed2ff25

  Copy full SHA for ed2ff25

Commits on Apr 30, 2020

• big getter refactoring

  sylviamoss

  committed
  d4b40f1

  Copy full SHA for d4b40f1

• fix format

  sylviamoss

  committed
  ac4a6cb

  Copy full SHA for ac4a6cb

Commits on May 4, 2020

• create detector chain of responsibility

  sylviamoss

  committed
  66ada4f

  Copy full SHA for 66ada4f

• Solve todos and improve comments

  sylviamoss

  committed
  fe63e44

  Copy full SHA for fe63e44

Commits on May 5, 2020

• Add smb windows getter

  sylviamoss

  committed
  bed918b

  Copy full SHA for bed918b

• Add missing next to detector

  sylviamoss

  committed
  f0c903b

  Copy full SHA for f0c903b

• Update smbmountgetter

  sylviamoss

  committed
  2bd83fd

  Copy full SHA for 2bd83fd

• fix format

  sylviamoss

  committed
  7f4c3d1

  Copy full SHA for 7f4c3d1

Commits on May 6, 2020

• make chain a loop

  sylviamoss

  committed
  4516534

  Copy full SHA for 4516534

Commits on May 7, 2020

• loop over getters and detect for each

  sylviamoss

  committed
  cfb908e

  Copy full SHA for cfb908e

• Remove ValidScheme api and move some detection logic to Getters

  sylviamoss

  committed
  e13d3ca

  Copy full SHA for e13d3ca

• change error handling

  sylviamoss

  committed
  9608b60

  Copy full SHA for 9608b60

• Merge branch 'v2' into getters_refactoring

  sylviamoss

  committed
  0a667db

  Copy full SHA for 0a667db

• fix path slash for windows

  sylviamoss

  committed
  227cd74

  Copy full SHA for 227cd74

• Update Request on detection

  sylviamoss

  committed
  816685a

  Copy full SHA for 816685a

• Fix tests

  sylviamoss

  committed
  00cab94

  Copy full SHA for 00cab94

• Fix error msg

  sylviamoss

  committed
  5f3ee0e

  Copy full SHA for 5f3ee0e

Commits on May 11, 2020

• Merge branch 'v2' into getters_refactoring

  sylviamoss

  committed
  913107c

  Copy full SHA for 913107c

• fix fmt

  sylviamoss

  committed
  7334366

  Copy full SHA for 7334366

• Fix build fail

  sylviamoss

  committed
  8af9373

  Copy full SHA for 8af9373

• Fix some code organization

  sylviamoss

  committed
  ad53e85

  Copy full SHA for ad53e85

• improve error handling

  sylviamoss

  committed
  caf16e8

  Copy full SHA for caf16e8

• fix main.go

  sylviamoss

  committed
  39a5cf7

  Copy full SHA for 39a5cf7

• logs to test windows tests on circleci

  sylviamoss

  committed
  1636ace

  Copy full SHA for 1636ace

• make filegetter accept win c:/ filepaths

  sylviamoss

  committed
  9e480d6

  Copy full SHA for 9e480d6

• override request directly

  sylviamoss

  committed
  e9fff33

  Copy full SHA for e9fff33

Commits on May 12, 2020

• Move some tests and make the code look better'

  sylviamoss

  committed
  93a026d

  Copy full SHA for 93a026d

• Fix fmt

  sylviamoss

  committed
  12cc1d0

  Copy full SHA for 12cc1d0

• Fix windows test

  sylviamoss

  committed
  cee4ecd

  Copy full SHA for cee4ecd

Commits on May 13, 2020

• Update Detect interface comment

  sylviamoss

  committed
  c5d18ea

  Copy full SHA for c5d18ea

• Update SmbMountGetter

  sylviamoss

  committed
  7327304

  Copy full SHA for 7327304

• Update README

  sylviamoss

  committed
  209cb28

  Copy full SHA for 209cb28

Commits on May 19, 2020

• Test refactoring circleci config

  sylviamoss

  committed
  a3dc9e0

  Copy full SHA for a3dc9e0

Commits on May 28, 2020

• Merge branch 'v2' into getters_refactoring

  sylviamoss

  committed
  b1504cd

  Copy full SHA for b1504cd

• move detectors back and add them to getters

  sylviamoss

  committed
  95f553a

  Copy full SHA for 95f553a

Commits on Jun 2, 2020

• Add detector tests back

  sylviamoss

  committed
  7072459

  Copy full SHA for 7072459

• Make SmbMountGetter MacOS and Windows specific

  sylviamoss

  committed
  6e2f08e

  Copy full SHA for 6e2f08e

Commits on Jun 3, 2020

• Explain better the code in comments

  sylviamoss

  committed
  1ab379b

  Copy full SHA for 1ab379b