Make checksum func public #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dynajoe
reviewed
May 14, 2020
checksum.go
Outdated
| @@ -67,7 +75,7 @@ func (c *FileChecksum) checksum(source string) error { | |||
| Hash: c.Hash, | |||
| Actual: actual, | |||
| Expected: c.Value, | |||
| File: source, | |||
| File: file, | |||
There was a problem hiding this comment.
This would return a closed file. Is that intended?
There was a problem hiding this comment.
Oh, I misread, file isn't the file it's the path.
There was a problem hiding this comment.
Would it be better to rename the variable then?
There was a problem hiding this comment.
I agree, I think that should probably be filePath !
SwampDragons
approved these changes
May 14, 2020
dynajoe
approved these changes
May 16, 2020
|
Thanks everyone ! 🙂 |
This was referenced Mar 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello there, we needed that functionality as a standalone one in Packer as we have some internal code that uploads artifacts to a remote instance and we then need to checksum it.
We could have copied it since all the fields of
FileChecksumare public but I thought this tiny improvement would be a little better.