Update mdns to 1.0.1 #132
Merged
Update mdns to 1.0.1 #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkeeler
reviewed
Dec 19, 2019
There was a problem hiding this comment.
One (maybe non-issue) I see is that the go.mod references github.com/miekg/dns @ v1.0.14. However in the mdns providers vendor file it looks like we vendored that library from master yesterday which is closer to the latest release of v1.1.25 (except that was released 8 days ago and we pulled in newere "unreleased" commits)
Do we need to keep the go.mod and the providers vendor file using the same versions of things? Should we then update the go.mod to call out v1.1.25 or a specific git revision?
added 2 commits
January 6, 2020 12:26
notnoop
force-pushed
the
b-update-mdns-20191218
branch
from
3fcc2f3 to
6a9235b
Compare
|
I have updated so the vendored files match go.mod - I chose to update that since it's the one we use and test in the nomad team. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update mdns dependency mostly to avoid old github.com/hashicorp/go.net fork of golang.org/x/net and pick up hashicorp/mdns#65
For go.mod, I confirmed that go.net is no longer referenced:
Before
After: