Update AWS SDK to latest #128
Conversation
| github.com/davecgh/go-spew v1.1.1 // indirect | ||
| github.com/denverdino/aliyungo v0.0.0-20170926055100-d3308649c661 | ||
| github.com/dgrijalva/jwt-go v3.2.0+incompatible // indirect | ||
| github.com/digitalocean/godo v1.1.1 | ||
| github.com/dimchansky/utfbom v1.1.0 // indirect |
There was a problem hiding this comment.
This is unrelated change but it looks like it's a dependency of github.com/Azure/go-autorest v.10.7.0 [1] but somehow we missed declaring it here.
[1] https://github.com/Azure/go-autorest/blob/v10.7.0/autorest/azure/auth/auth.go#L34
There was a problem hiding this comment.
Is this the most conservative update that includes the things we need?
FWIW Consul now pulls in 1.25.42 anyway thanks to recent AWS CA provider work and we tested go-discover integration afterwards and it works.
There was a problem hiding this comment.
Oops - I had updated it to v1.25.41 the most recent release with ec2metadata changes[1]. I accidentally updated it with v1.15.41 earlier.
There was a problem hiding this comment.
Correction: Consul pulls in v1.25.32 which is what I tested with go-discover stuff.
Let me sanity check Consul AWS cloud auto join with 1.25.41 and then we can call this good.
There was a problem hiding this comment.
Yep works with 1.25.41:
$ go get github.com/aws/[email protected]
...
$ make dev
$ envchain csl consul agent -retry-join "provider=aws tag_key=Role tag_value=consul-server region=us-west-1" -data-dir "/tmp/consul"
...
2019/12/02 15:26:47 [INFO] agent: Discovered LAN servers: 10.0.1.241 10.0.1.174 10.0.1.12 10.0.1.33 10.0.1.237 10.0.1.44 10.0.1.11 10.0.1.156 10.0.1.28
...(We have dev servers running in that region so this discovered those and could join them.
Update to the latest AWS SDK to pick up EC2 Instance Metadata Service v2 support, announced in Nov 19, 2019. Updating it here is necessary for downstream projects that haven't adopted go mod (e.g. Nomad), and rely on vendored provider packages here. For more info on IMDSv2: https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/ec2-instance-metadata.html . This updates version to v1.25.41, the latest version with ec2metadata changes.
notnoop
force-pushed
the
c-vendor-aws-v1.15.41
branch
from
0ad4019 to
b18ea84
Compare
| github.com/davecgh/go-spew v1.1.1 // indirect | ||
| github.com/denverdino/aliyungo v0.0.0-20170926055100-d3308649c661 | ||
| github.com/dgrijalva/jwt-go v3.2.0+incompatible // indirect | ||
| github.com/digitalocean/godo v1.1.1 | ||
| github.com/dimchansky/utfbom v1.1.0 // indirect |
There was a problem hiding this comment.
Yep works with 1.25.41:
$ go get github.com/aws/[email protected]
...
$ make dev
$ envchain csl consul agent -retry-join "provider=aws tag_key=Role tag_value=consul-server region=us-west-1" -data-dir "/tmp/consul"
...
2019/12/02 15:26:47 [INFO] agent: Discovered LAN servers: 10.0.1.241 10.0.1.174 10.0.1.12 10.0.1.33 10.0.1.237 10.0.1.44 10.0.1.11 10.0.1.156 10.0.1.28
...(We have dev servers running in that region so this discovered those and could join them.
|
I also ran our integration tests for the new CA using this version for completeness and got a pass: |
|
Thanks! |
Update github.com/aws/aws-sdk-go and github.com/hashicorp/go-discover to pick up support for EC2 Metadata Instance Service v2 changes. Follow up to hashicorp/go-discover#128 .
Update github.com/aws/aws-sdk-go and github.com/hashicorp/go-discover to pick up support for EC2 Metadata Instance Service v2 changes. Follow up to hashicorp/go-discover#128 .
Refs hashicorp/go-discover#128 * deps: add replace directive for gocheck Transitive dep, source at https://launchpad.net/gocheck indicates project moved. This also avoids a dependency on bzr when fetching modules. Refs #6818 * deps: make update-vendor * test: update retry-join expected names from go-discover
Update to the latest AWS SDK to pick up EC2 Instance Metadata Service v2
support, announced in Nov 19, 2019. Updating it here is necessary for
downstream projects that haven't adopted go mod (e.g. Nomad), and rely
on vendored provider packages here.
For more info on IMDSv2:
https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/ec2-instance-metadata.html
.