-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
missing map key match operator dispositions #38
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schmichael
requested review from
jefferai,
mkeeler,
a team,
modrake and
jeanneryan
and removed request for
a team
April 21, 2023 17:00
mkeeler
approved these changes
Apr 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shore
approved these changes
Apr 21, 2023
jefferai
approved these changes
Apr 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
jefferai
added a commit
to hashicorp/boundary
that referenced
this pull request
Apr 26, 2023
This normalizes behavior around missing map keys. See hashicorp/go-bexpr#38 for more information.
jefferai
added a commit
to hashicorp/boundary
that referenced
this pull request
Apr 26, 2023
This normalizes behavior around missing map keys. See hashicorp/go-bexpr#38 for more information.
schmichael
added a commit
to hashicorp/nomad
that referenced
this pull request
Apr 26, 2023
schmichael
added a commit
to hashicorp/nomad
that referenced
this pull request
Apr 27, 2023
This was referenced Apr 27, 2023
Closed
Merged
schmichael
added a commit
to hashicorp/nomad
that referenced
this pull request
May 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements MatchOperator.NotPresentDisposition to determine an operator's behavior when a map key in the selector is not found.
Fixes #35
Replaces #36