Update overlay token values #646
Conversation
…x-shadow and elevation-overlay-box-shadow tokens
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: ecbe26d The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@didoo marking this as a draft since I haven't made updates to the token library before. Would love your feedback, for context the changes that were made can be found in the Figma Foundations here. Since this is a visual update and change in the values, does this need a changeset? |
There was a problem hiding this comment.
@jorytindall all good for me! great job! 🙌
yes, you need to add a changeset, instructions here: https://github.com/hashicorp/design-system/blob/main/packages/components/NEW-COMPONENT-CHECKLIST.md#component-review
add a changelog update via Changesets if needed using the command
yarn changeset(in the project root)
| @@ -1,6 +1,6 @@ | |||
| /** | |||
| * Do not edit directly | |||
| * Generated on Sat, 16 Jul 2022 14:15:33 GMT | |||
| * Generated on Wed, 19 Oct 2022 16:34:46 GMT | |||
There was a problem hiding this comment.
[nitpick] Not an issue per se, but for general knowledge: when you run a yarn build for the tokens, the dates are updated in every generated file. As a matter or reducing the overall noise, I tend to not commit these files (with only the date changed) but it's OK anyway.
There was a problem hiding this comment.
not really urgent to address, but how hard would it be to not update these dates if the file hasn't actually changed?
There was a problem hiding this comment.
Last time I looked at it was not so obvious (also see: amzn/style-dictionary#768)
|
FYI I have already approved the failing visual regression test (it's expected to be like this) |
📌 Summary
If merged this PR will update the values of the
token-surface-overlay-box-shadowandtoken-elevation-overlay-box-shadowto match the visual language updates made during the dialog work.As a note: the values being revised were defined prior to having a context to use them in, upon establishing the context of the dialog and modal components some necessary updates were made to soften and maintain consistency with the rest of the elevation and surface box shadow styles.
👀 How to review
👉 Review commit-by-commit
👉 Review by files changed
Reviewer's checklist:
💬 Please consider using conventional comments when reviewing this PR.