Code

Add Modal component#631

Code

Merged

alex-ju merged 54 commits intomainhashicorp/design-system:mainfrom alex-ju/add-dialog-componenthashicorp/design-system:alex-ju/add-dialog-componentCopy head branch name to clipboardNov 21, 2022

+1,641-31

Commits

Commits on Nov 21, 2022

• Generate Hds::Dialog component

  alex-ju

  committed
  c5ecbda

  Copy full SHA for c5ecbda

• Generate documentation for Hds::Dialog

  alex-ju

  committed
  1059885

  Copy full SHA for 1059885

• Add Hds::Dialog to visual regression tests

  alex-ju

  committed
  20b3de9

  Copy full SHA for 20b3de9

• Split Hds::Dialog in subcomponents and add basic styling

  Show description for e79c327
  alex-ju

  committed
  e79c327

  Copy full SHA for e79c327

• Add @size argument to Hds::Dialog

  alex-ju

  committed
  ee8ee01

  Copy full SHA for ee8ee01

• Add @type argument to Hds::Dialog

  alex-ju

  committed
  2b414ad

  Copy full SHA for 2b414ad

• Set aria-labelledby to dialog title

  alex-ju

  committed
  6c9cf00

  Copy full SHA for 6c9cf00

• Setup modal dialog on insert

  alex-ju

  committed
  0184431

  Copy full SHA for 0184431

• Close dialog on dismiss

  alex-ju

  committed
  87a7824

  Copy full SHA for 87a7824

• Close dialog on click 'outside'

  Show description for 93ecfc9
  alex-ju

  committed
  93ecfc9

  Copy full SHA for 93ecfc9

• Allow onClose callback function

  alex-ju

  committed
  c01e96c

  Copy full SHA for c01e96c

• Allow onOpen callback function

  alex-ju

  committed
  0df763c

  Copy full SHA for 0df763c

• Rename @type→@color and regular→medium

  alex-ju

  committed
  5c58612

  Copy full SHA for 5c58612

• Update box-shadow token from higher to overlay

  alex-ju

  committed
  33a752a

  Copy full SHA for 33a752a

• Use helper classes for typography declarations

  alex-ju

  committed
  9d6a97e

  Copy full SHA for 9d6a97e

• Add @tagline to dialog title

  alex-ju

  committed
  db1cbbe

  Copy full SHA for db1cbbe

• Place tertiary buttons at the end of the row

  alex-ju

  committed
  b5ce429

  Copy full SHA for b5ce429

• Trap focus within the dialog when active

  Show description for 7c4a39a
  alex-ju

  committed
  7c4a39a

  Copy full SHA for 7c4a39a

• Use bespoke overlay element instead of ::backdrop pseudoelement

  Show description for cd902b9
  alex-ju

  committed
  cd902b9

  Copy full SHA for cd902b9

• Add 'Showcase' section (interim)

  alex-ju

  committed
  ad681d3

  Copy full SHA for ad681d3

• Rename Hds::Dialog→Hds::Modal

  alex-ju

  committed
  7c78c93

  Copy full SHA for 7c78c93

• Add 'Overview', 'API', 'Accessibility', 'Showcase'

  alex-ju

  committed
  743e3e9

  Copy full SHA for 743e3e9

• Apply spacing adjustments

  alex-ju

  committed
  2adbfef

  Copy full SHA for 2adbfef

• Rationalize focus management on open

  alex-ju

  committed
  e32b051

  Copy full SHA for e32b051

• Remove redundant isOpen attribute

  Show description for f6fd4f4
  alex-ju

  committed
  f6fd4f4

  Copy full SHA for f6fd4f4

• Ensure modal is positioned on top of codeblocks

  alex-ju

  committed
  8a84ddc

  Copy full SHA for 8a84ddc

• Mark M.Header as required

  Show description for b0444d4
  alex-ju

  committed
  b0444d4

  Copy full SHA for b0444d4

• Add dialog-polyfill

  Show description for 39f44bb
  alex-ju

  committed
  39f44bb

  Copy full SHA for 39f44bb

• Update tests to cover functionality

  alex-ju

  committed
  2ee513a

  Copy full SHA for 2ee513a

• Abstract dismiss button as Hds::DismissButton

  Show description for 9025515
  alex-ju

  committed
  9025515

  Copy full SHA for 9025515

• Move @actions at the end of the file

  Show description for a6ce0b9
  

  alex-ju

  and

  didoo

  committed
  a6ce0b9

  Copy full SHA for a6ce0b9

• Improve documentation based on feedback

  Show description for 882b927
  

  alex-ju

  and

  MelSumner

  committed
  882b927

  Copy full SHA for 882b927

• Rename @isActive→@isOpen

  Show description for 0d49044
  alex-ju

  committed
  0d49044

  Copy full SHA for 0d49044

• Remove unused noop function

  Show description for 78b551d
  alex-ju

  committed
  78b551d

  Copy full SHA for 78b551d

• Remove unnecessary assertions

  alex-ju

  committed
  12b6a05

  Copy full SHA for 12b6a05

• Add test for overlay element

  alex-ju

  committed
  10d5c7e

  Copy full SHA for 10d5c7e

• Rename close→onDismiss

  alex-ju

  committed
  73f4fa4

  Copy full SHA for 73f4fa4

• Rename setup→didInsert

  alex-ju

  committed
  183fa3c

  Copy full SHA for 183fa3c

• Add tests for the callback functions

  alex-ju

  committed
  ca2e399

  Copy full SHA for ca2e399

• Set a default z-index value

  alex-ju

  committed
  159ad50

  Copy full SHA for 159ad50

• auto-import dialog-polyfill

  

  Dhaulagiri

  authored and

  alex-ju

  committed
  22b3e7f

  Copy full SHA for 22b3e7f

• Set body overflow to auto

  Show description for 49a4322
  alex-ju

  committed
  49a4322

  Copy full SHA for 49a4322

• Update dismiss-button test

  Show description for 467c3c7
  alex-ju

  committed
  467c3c7

  Copy full SHA for 467c3c7

• Skip flakey test for onClose callback

  alex-ju

  committed
  68d0f15

  Copy full SHA for 68d0f15

• Remove redundant mention of ...attributes support

  alex-ju

  committed
  482122e

  Copy full SHA for 482122e

• Disable pointer events on modal dismiss button

  Show description for 6e84a06
  alex-ju

  committed
  6e84a06

  Copy full SHA for 6e84a06

• Add design guidelines

  alex-ju

  committed
  4a382c5

  Copy full SHA for 4a382c5

• Add changelog entry

  alex-ju

  committed
  5d4b181

  Copy full SHA for 5d4b181

• Allow modal to be prevented from closing via onClose callback function

  Show description for 051fba0
  alex-ju

  committed
  051fba0

  Copy full SHA for 051fba0

• Expose a close function in the footer

  Show description for 5781e35
  alex-ju

  committed
  5781e35

  Copy full SHA for 5781e35

• Describe usage of and requirements for ember-focus-trap

  alex-ju

  committed
  18f508e

  Copy full SHA for 18f508e

• Fix button type on secondary and tertiary actions

  Show description for cc61909
  

  alex-ju

  and

  MelSumner

  committed
  cc61909

  Copy full SHA for cc61909

• Add isDismissDisabled property

  Show description for efb3ea6
  alex-ju

  committed
  efb3ea6

  Copy full SHA for efb3ea6

• Update changelog entry

  alex-ju

  committed
  9129e59

  Copy full SHA for 9129e59